Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752960AbbBXVbl (ORCPT ); Tue, 24 Feb 2015 16:31:41 -0500 Received: from mout.gmx.net ([212.227.15.19]:55126 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751908AbbBXVbj (ORCPT ); Tue, 24 Feb 2015 16:31:39 -0500 Message-ID: <54ECED97.5070500@gmx.de> Date: Tue, 24 Feb 2015 22:31:03 +0100 From: Heinrich Schuchardt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: David Rientjes CC: Andrew Morton , Aaron Tomlin , Andy Lutomirski , Davidlohr Bueso , "David S. Miller" , Fabian Frederick , Guenter Roeck , "H. Peter Anvin" , Ingo Molnar , Jens Axboe , Joe Perches , Johannes Weiner , Kees Cook , Michael Marineau , Oleg Nesterov , "Paul E. McKenney" , Peter Zijlstra , Prarit Bhargava , Rik van Riel , Rusty Russell , Steven Rostedt , Thomas Gleixner , Vladimir Davydov , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] kernel/sysctl.c: threads-max observe limits References: <1424722477-23758-1-git-send-email-xypron.glpk@gmx.de> <1424806701-30099-1-git-send-email-xypron.glpk@gmx.de> <1424806701-30099-4-git-send-email-xypron.glpk@gmx.de> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3dxWR3SEo2YmJiornMrAa5SFk+JP8G7aQg28NVM5AX8nZ3P52SK bo81xa99a4iX4JF92vZEXLl5GG69XDY9hOzsBDMpsTmM0oJKXnOP7dxk5g/sslRJtoi9+oJ XNOVkqCluJ1kTzMoFmZ2I9BTiYmDlgMxo7S5uNtf1Xd2H5e0N715vuz6czsR5Hvp00YU/Q/ /uIq92LvSh/CkuB6C8gpg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3562 Lines: 119 On 24.02.2015 22:17, David Rientjes wrote: > On Tue, 24 Feb 2015, Heinrich Schuchardt wrote: > >> Users can change the maximum number of threads by writing to >> /proc/sys/kernel/threads-max. >> >> With the patch the value entered is checked against the same >> limits that apply when fork_init is called. >> > > Correct me if I'm wrong, but this is a change in functionality (without > update to Documentation/sysctl/kernel.txt which describes threads-max) > since it does not allow the value to be lowered as before from the > calculation involving totalram_pages. The value passed to > set_max_threads() only caps the value. threads_max is set to the value the user inputs if it is inside the interval [20, FUTEX_TID_MASK] and it is capped by the value calculated from totalram_pages. So lowering and raising is still possible (inside the limits). > >> Signed-off-by: Heinrich Schuchardt >> --- >> include/linux/sysctl.h | 3 +++ >> kernel/fork.c | 24 ++++++++++++++++++++++++ >> kernel/sysctl.c | 6 ++---- >> 3 files changed, 29 insertions(+), 4 deletions(-) >> >> diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h >> index b7361f8..795d5fe 100644 >> --- a/include/linux/sysctl.h >> +++ b/include/linux/sysctl.h >> @@ -212,4 +212,7 @@ static inline void setup_sysctl_set(struct ctl_table_set *p, >> >> #endif /* CONFIG_SYSCTL */ >> >> +int sysctl_max_threads(struct ctl_table *table, int write, >> + void __user *buffer, size_t *lenp, loff_t *ppos); >> + >> #endif /* _LINUX_SYSCTL_H */ >> diff --git a/kernel/fork.c b/kernel/fork.c >> index 880c78d..52a07c7 100644 >> --- a/kernel/fork.c >> +++ b/kernel/fork.c >> @@ -74,6 +74,7 @@ >> #include >> #include >> #include >> +#include >> >> #include >> #include >> @@ -2024,3 +2025,26 @@ int unshare_files(struct files_struct **displaced) >> task_unlock(task); >> return 0; >> } >> + >> +int sysctl_max_threads(struct ctl_table *table, int write, >> + void __user *buffer, size_t *lenp, loff_t *ppos) >> +{ >> + struct ctl_table t; >> + int ret; >> + int threads = max_threads; >> + int min = MIN_THREADS; >> + int max = MAX_THREADS; >> + >> + t = *table; >> + t.data = &threads; >> + t.extra1 = &min; >> + t.extra2 = &max; >> + >> + ret = proc_dointvec_minmax(&t, write, buffer, lenp, ppos); >> + if (ret || !write) >> + return ret; >> + >> + set_max_threads(threads); >> + >> + return 0; >> +} >> diff --git a/kernel/sysctl.c b/kernel/sysctl.c >> index 137c7f6..2e195ae 100644 >> --- a/kernel/sysctl.c >> +++ b/kernel/sysctl.c >> @@ -92,11 +92,9 @@ >> #include >> #endif >> >> - >> #if defined(CONFIG_SYSCTL) >> >> /* External variables not in a header file. */ >> -extern int max_threads; >> extern int suid_dumpable; >> #ifdef CONFIG_COREDUMP >> extern int core_uses_pid; >> @@ -709,10 +707,10 @@ static struct ctl_table kern_table[] = { >> #endif >> { >> .procname = "threads-max", >> - .data = &max_threads, >> + .data = NULL, >> .maxlen = sizeof(int), >> .mode = 0644, >> - .proc_handler = proc_dointvec, >> + .proc_handler = sysctl_max_threads, >> }, >> { >> .procname = "random", > Best regards Heinrich -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/