Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753172AbbBXWDw (ORCPT ); Tue, 24 Feb 2015 17:03:52 -0500 Received: from lists.s-osg.org ([54.187.51.154]:38060 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234AbbBXWDu (ORCPT ); Tue, 24 Feb 2015 17:03:50 -0500 Date: Tue, 24 Feb 2015 19:03:46 -0300 From: Mauro Carvalho Chehab To: Shuah Khan Cc: hans.verkuil@cisco.com, prabhakar.csengg@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug Message-ID: <20150224190346.4cf0b439@recife.lan> In-Reply-To: <1424804014-7743-1-git-send-email-shuahkh@osg.samsung.com> References: <1424804014-7743-1-git-send-email-shuahkh@osg.samsung.com> Organization: Samsung X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1201 Lines: 39 Em Tue, 24 Feb 2015 11:53:34 -0700 Shuah Khan escreveu: > Replace printk KERN_DEBUG with pr_debug in dprintk macro > defined in au0828.h > > Signed-off-by: Shuah Khan > --- > drivers/media/usb/au0828/au0828.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/au0828/au0828.h b/drivers/media/usb/au0828/au0828.h > index eb15187..e3e90ea 100644 > --- a/drivers/media/usb/au0828/au0828.h > +++ b/drivers/media/usb/au0828/au0828.h > @@ -336,7 +336,7 @@ extern struct vb2_ops au0828_vbi_qops; > > #define dprintk(level, fmt, arg...)\ > do { if (au0828_debug & level)\ > - printk(KERN_DEBUG pr_fmt(fmt), ## arg);\ > + pr_debug(pr_fmt(fmt), ## arg);\ NACK. This is the worse of two words, as it would require both to enable each debug line via dynamic printk setting and to enable au0828_debug. Regards, Mauro > } while (0) > > /* au0828-input.c */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/