Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753238AbbBXWKn (ORCPT ); Tue, 24 Feb 2015 17:10:43 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:43297 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbbBXWKm (ORCPT ); Tue, 24 Feb 2015 17:10:42 -0500 Date: Wed, 25 Feb 2015 01:10:28 +0300 From: Dan Carpenter To: Ameen Ali Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404. Message-ID: <20150224221028.GC5064@mwanda> References: <1424811631-10607-1-git-send-email-ameenali023@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424811631-10607-1-git-send-email-ameenali023@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 498 Lines: 15 On Tue, Feb 24, 2015 at 11:00:31PM +0200, Ameen Ali wrote: > else if at line 406 has the same condition as the else if at line 404. > The changelog should really say why you think 0x5 is correct. Could you update and resend? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/