MIME-Version: 1.0
In-Reply-To: <54ED02CA.4030007@zytor.com>
References: <1424803895-4420-1-git-send-email-dvlasenk@redhat.com>
 <CALCETrVretXX1Wgx9TNQH67XH=M6fGA+L+7agyp0Fm8503Ey9w@mail.gmail.com>
 <54ED00B5.3020203@zytor.com> <CALCETrV5PkXo4TXx0de-tYs2reZmKKRzN04NOrhv+FSmzKs=hg@mail.gmail.com>
 <54ED02CA.4030007@zytor.com>
From: Andy Lutomirski <luto@amacapital.net>
Date: Tue, 24 Feb 2015 15:03:54 -0800
Message-ID: <CALCETrXqjNNWUaZQi4XNgABzWY0+w7Y7VcqeVht5SDrp6se+GQ@mail.gmail.com>
Subject: Re: [PATCH 1/4] x86: entry.S: tidy up several suboptimal insns
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@kernel.org>,
        Borislav Petkov <bp@alien8.de>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1464
Lines: 50

On Tue, Feb 24, 2015 at 3:01 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 02/24/2015 02:56 PM, Andy Lutomirski wrote:
>> On Tue, Feb 24, 2015 at 2:52 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>>> On 02/24/2015 02:25 PM, Andy Lutomirski wrote:
>>>> On Tue, Feb 24, 2015 at 10:51 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
>>>>> In all three 32-bit entry points, %eax is zero-extended to %rax.
>>>>> It is safe to do 32-bit compare when checking that syscall#
>>>>> is not too large.
>>>>
>>>> Applied.  Thanks!
>>>>
>>>
>>> NAK NAK NAK NAK NAK!!!!
>>>
>>> We have already had this turn into a security issue not just once but
>>> TWICE, because someone decided to "optimize" the path by taking out the
>>> zero extend.
>>>
>>> The use of a 64-bit compare here is an intentional "belts and
>>> suspenders" safety issue.
>>
>> Fair enough.  OK if I just undo that part of this patch?
>>
>
> Actually this part should have been broken up.  The word "several" in
> the patch description is by itself a cause to NAK the patch.

Point taken.

Denys, can you fix this and send a v2 of the entire series with the
traps.c fix as well?

Thanks,
Andy

>
>         -hpa
>
>


-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/