Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbbBXXN3 (ORCPT ); Tue, 24 Feb 2015 18:13:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59144 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbbBXXN2 (ORCPT ); Tue, 24 Feb 2015 18:13:28 -0500 Date: Wed, 25 Feb 2015 00:12:31 +0100 From: Jiri Olsa To: Steven Rostedt Cc: Jiri Olsa , linux-kernel@vger.kernel.org, Wang Nan , Arnaldo Carvalho de Melo , David Ahern , Frederic Weisbecker , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Sebastian Andrzej Siewior , Tom Zanussi Subject: Re: [PATCH 09/11] tools lib traceevent: Add alias field to struct format_field Message-ID: <20150224231231.GA8478@krava.redhat.com> References: <1424470628-5969-1-git-send-email-jolsa@kernel.org> <1424470628-5969-10-git-send-email-jolsa@kernel.org> <20150224225458.GB3042@home.goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150224225458.GB3042@home.goodmis.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1329 Lines: 35 On Tue, Feb 24, 2015 at 05:54:58PM -0500, Steven Rostedt wrote: > On Fri, Feb 20, 2015 at 11:17:06PM +0100, Jiri Olsa wrote: > > --- > > tools/lib/traceevent/event-parse.c | 1 + > > tools/lib/traceevent/event-parse.h | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > > index afe20ed9fac8..b35664cc1edc 100644 > > --- a/tools/lib/traceevent/event-parse.c > > +++ b/tools/lib/traceevent/event-parse.c > > @@ -6236,6 +6236,7 @@ static void free_format_fields(struct format_field *field) > > next = field->next; > > free(field->type); > > free(field->name); > > + free(field->alias); > > Hmm, didn't we say that if there's no need for the alias that the alias will > simply be a pointer to name? If that's the case we need: > > if (field->alias != field->name) > free(field->alias); > free(field->name); > > Otherwise it will be a double free. i used it separately.. like if there's no alias it's set to NULL, but I'll add the logic you described and repost, it seems ok jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/