Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753167AbbBXXrm (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Feb 2015 18:47:42 -0500
Received: from TYO201.gate.nec.co.jp ([210.143.35.51]:47550 "EHLO
	tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752244AbbBXXrl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Feb 2015 18:47:41 -0500
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: "Tantilov, Emil S" <emil.s.tantilov@intel.com>,
        "Skidmore, Donald C" <donald.c.skidmore@intel.com>,
        "vyasevic@redhat.com" <vyasevic@redhat.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
CC: "e1000-devel@lists.sourceforge.net" 
	<e1000-devel@lists.sourceforge.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Choi, Sy Jong" <sy.jong.choi@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Laight <David.Laight@ACULAB.COM>,
        Hayato Momma <h-momma@ce.jp.nec.com>,
        =?ks_c_5601-1987?B?QmqpqnJuIE1vcms=?= <bjorn@mork.no>
Subject: RE: [E1000-devel] [PATCH v2 3/3] ixgbe: Add new ndo to allow VF
 multicast promiscuous mode
Thread-Topic: [E1000-devel] [PATCH v2 3/3] ixgbe: Add new ndo to allow VF
 multicast promiscuous mode
Thread-Index: AdBMqK/iyr+mPXpITtC290u8yo2+tgDx5plQAAYsCWA=
Date: Tue, 24 Feb 2015 23:43:32 +0000
Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD05E3F1D9@BPXM14GP.gisp.nec.co.jp>
References: <7F861DC0615E0C47A872E6F3C5FCDDBD05E38867@BPXM14GP.gisp.nec.co.jp>
 <87618083B2453E4A8714035B62D6799250241E02@FMSMSX105.amr.corp.intel.com>
In-Reply-To: <87618083B2453E4A8714035B62D6799250241E02@FMSMSX105.amr.corp.intel.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.205.5.123]
Content-Type: text/plain; charset="ks_c_5601-1987"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id t1ONlpAx023171
Content-Length: 1890
Lines: 58

> >-----Original Message-----
> >From: Hiroshi Shimamoto [mailto:h-shimamoto@ct.jp.nec.com]
> >Sent: Thursday, February 19, 2015 5:01 PM
> > Subject: [E1000-devel] [PATCH v2 3/3] ixgbe: Add new ndo to allow VF multicast promiscuous mode
> >
> >From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> >
> >Implements the new netdev op to allow VF multicast promiscuous mode.
> >
> >The administrator can allow to VF multicast promiscuous mode for only
> >trusted VM. After allowing multicast promiscuous mode from the host,
> >we can use over 30 IPv6 addresses on VM.
> > # ./ip link set dev eth0 vf 1 mc_promisc on
> >
> >When disallowing multicast promiscuous mode, we can only use 30 IPv6 addresses.
> > # ./ip link set dev eth0 vf 1 mc_promisc off
> >
> >Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> >Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
> >CC: Choi, Sy Jong <sy.jong.choi@intel.com>
> 
> <snip>
> 
> +int ixgbe_ndo_set_vf_mc_promisc(struct net_device *netdev, int vf, bool setting)
> +{
> +	struct ixgbe_adapter *adapter = netdev_priv(netdev);
> +	struct ixgbe_hw *hw = &adapter->hw;
> +	u32 vmolr;
> 
> vmolr is unused variable in this function.
> 
> +
> +	if (vf >= adapter->num_vfs)
> +		return -EINVAL;
> +
> +	/* nothing to do */
> +	if (adapter->vfinfo[vf].mc_promisc_allowed == setting)
> +		return 0;
> +
> +	adapter->vfinfo[vf].mc_promisc_allowed = setting;
> +
> +	/* if VF requests multicast promiscuous */
> +	if (adapter->vfinfo[vf].mc_promisc) {
> +		if (setting)
> +			ixgbe_enable_vf_mc_promisc(adapter, vf);
> +		else
> +			ixgbe_disable_vf_mc_promisc(adapter, vf);
> +	}
> +
> +	return 0;
> +}

thank you for pointing it.
I realized it and am preparing a patch.

thanks,
Hiroshi
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?