Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753238AbbBYBHo (ORCPT ); Tue, 24 Feb 2015 20:07:44 -0500 Received: from mail-oi0-f42.google.com ([209.85.218.42]:46199 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbbBYBHn convert rfc822-to-8bit (ORCPT ); Tue, 24 Feb 2015 20:07:43 -0500 MIME-Version: 1.0 In-Reply-To: <54EC638E.1060007@mentor.com> References: <54EB4C83.2000500@suse.cz> <54EC638E.1060007@mentor.com> From: Lucas De Marchi Date: Tue, 24 Feb 2015 22:07:22 -0300 Message-ID: Subject: Re: Differences between builtins and modules To: Harish Jenny Kandiga Nagaraj Cc: Michal Marek , Rusty Russell , linux-modules , lkml , greg KH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1327 Lines: 30 On Tue, Feb 24, 2015 at 8:42 AM, Harish Jenny Kandiga Nagaraj wrote: > > On Monday 23 February 2015 09:21 PM, Michal Marek wrote: >> On 2015-02-23 15:30, Lucas De Marchi wrote: > Can we add some flag like > KMOD_PROBE_FORCE_DIRECTORY_CHECK = 0x00040, > and pass it to kmod_module_get_initstate to make > "modprobe --show-depends vt" to report as "builtin" ? I don't want to add more flags. It's already pretty complicated, more than it should IMO. If the tools using kmod can live with the change proposed here, I'm ok with that. > Also if the use case for loading builtin modules is not that common > ( Also don’t know if 'modprobe vt' command does the loading if not loaded) > can we have the same flags be used after checking if it is .ko file or from .o file if required? Well... there's no way for us to arrive at the final call to finit_module() for a builtin module. Simply because there's no file to load in memory (or fd to open) to pass to these functions. We simply fail because we can't reach that far in the code. -- Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/