Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752755AbbBYEht (ORCPT ); Tue, 24 Feb 2015 23:37:49 -0500 Received: from mga09.intel.com ([134.134.136.24]:55104 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbbBYEhs (ORCPT ); Tue, 24 Feb 2015 23:37:48 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,643,1418112000"; d="scan'208";a="683022230" From: Wanpeng Li To: Ingo Molnar , Peter Zijlstra Cc: Juri Lelli , , linux-kernel@vger.kernel.org, Wanpeng Li Subject: [PATCH RESEND v2] sched/deadline: fix rt runtime corrupt when dl refuse a smaller bandwidth Date: Wed, 25 Feb 2015 12:37:22 +0800 Message-Id: <1424839042-97347-1-git-send-email-wanpeng.li@linux.intel.com> X-Mailer: git-send-email 1.7.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1859 Lines: 56 Dl class will refuse the bandwidth being set to some value smaller than the currently allocated bandwidth in any of the root_domains through sched_rt_runtime_us and sched_rt_period_us. RT runtime will be set according to sched_rt_runtime_us before dl class verify if the new bandwidth is suitable in the case of !CONFIG_RT_GROUP_SCHED. However, rt runtime will be corrupt if dl refuse the new bandwidth since there is no undo to reset the rt runtime to the old value. This patch fix it by verifying new bandwidth for deadline in advance. Cc: Juri Lelli Signed-off-by: Wanpeng Li --- v1 -> v2: * move sched_dl_global_constraints before sched_rt_global_constraints, and change the name of the former to sched_dl_global_validate(). kernel/sched/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 97fe79c..e884909 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -7815,7 +7815,7 @@ static int sched_rt_global_constraints(void) } #endif /* CONFIG_RT_GROUP_SCHED */ -static int sched_dl_global_constraints(void) +static int sched_dl_global_validate(void) { u64 runtime = global_rt_runtime(); u64 period = global_rt_period(); @@ -7916,11 +7916,11 @@ int sched_rt_handler(struct ctl_table *table, int write, if (ret) goto undo; - ret = sched_rt_global_constraints(); + ret = sched_dl_global_validate(); if (ret) goto undo; - ret = sched_dl_global_constraints(); + ret = sched_rt_global_constraints(); if (ret) goto undo; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/