Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751229AbbBYGIm (ORCPT ); Wed, 25 Feb 2015 01:08:42 -0500 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35247 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbbBYGIl (ORCPT ); Wed, 25 Feb 2015 01:08:41 -0500 Date: Wed, 25 Feb 2015 08:08:36 +0200 From: Aya Mahfouz To: Joe Perches Cc: Andy Whitcroft , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] scripts: checkpatch.pl: add 2 new checks on memset calls Message-ID: <20150225060836.GA12255@waves> References: <20150225024043.GA9120@localhost.localdomain> <1424833852.11070.1.camel@perches.com> <20150225043521.GB9220@localhost.localdomain> <1424839283.11070.9.camel@perches.com> <20150225045907.GC9220@localhost.localdomain> <1424843143.11070.11.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424843143.11070.11.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3883 Lines: 98 On Tue, Feb 24, 2015 at 09:45:43PM -0800, Joe Perches wrote: > On Wed, 2015-02-25 at 06:59 +0200, Aya Mahfouz wrote: > > On Tue, Feb 24, 2015 at 08:41:23PM -0800, Joe Perches wrote: > > > On Wed, 2015-02-25 at 06:35 +0200, Aya Mahfouz wrote: > > > > On Tue, Feb 24, 2015 at 07:10:52PM -0800, Joe Perches wrote: > > > > > On Wed, 2015-02-25 at 04:40 +0200, Aya Mahfouz wrote: > > > > > > This patch adds 2 new checks on memset calls in the file > > > > > > checkpatch.pl as follows: > > > [] > > > > ok, I didn't see your suggestion, sorry. > > > > > > No worries. > > > > > > > Can you look at the following > > > > modification before sending the third patch? I don't use $stat because > > > > I get false positives with it. > > > > > > Please describe the false positives. > > > > > > > > > > ok, here are the relevant warnings issued by checkpatch.pl when using > > $stat for the file drivers/staging/rtl8188eu/os_dep/ioctl_linux.c. > > The only correct results are lines 95, 830, 1031, 1040, 1908. > > > > WARNING: Prefer eth_zero_addr() over memset() if the second address is 0x00 > > #95: FILE: drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:95: > > + memset(wrqu.ap_addr.sa_data, 0, ETH_ALEN); > > > > > > WARNING: Prefer eth_zero_addr() over memset() if the second address is 0x00 > > #775: FILE: drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:775: > > +} > > [] > > Try this: > --- > scripts/checkpatch.pl | 21 +++++++++++++++++---- > 1 file changed, 17 insertions(+), 4 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index d124359..9127c65 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -4890,10 +4890,11 @@ sub process { > } > } > > -# Check for misused memsets > +# Check for misused memsets then check for memset(foo, 0x00|0xff, ETH_ALEN) > +# calls that could be eth_zero_addr(foo)|eth_broadcast_addr(foo) > if ($^V && $^V ge 5.10.0 && > defined $stat && > - $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*$FuncArg\s*\)/s) { > + $stat =~ /^\+(?:\s*$Ident\s*=)?\s*memset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*$FuncArg\s*\)/s) { > > my $ms_addr = $2; > my $ms_val = $7; > @@ -4901,10 +4902,22 @@ sub process { > > if ($ms_size =~ /^(0x|)0$/i) { > ERROR("MEMSET", > - "memset to 0's uses 0 as the 2nd argument, not the 3rd\n" . "$here\n$stat\n"); > + "memset to 0's uses 0 as the 2nd argument, not the 3rd\n" . "$here\n$line\n"); > } elsif ($ms_size =~ /^(0x|)1$/i) { > WARN("MEMSET", > - "single byte memset is suspicious. Swapped 2nd/3rd argument?\n" . "$here\n$stat\n"); > + "single byte memset is suspicious. Swapped 2nd/3rd argument?\n" . "$here\n$line\n"); > + } elsif ($ms_val =~ /^(?:0x)?0+$/i && > + $ms_size =~ /^ETH_ALEN$/ && > + WARN("PREFER_ETH_ADDR", > + "Prefer eth_zero_addr() over memset() if the second address is 0\n" . $herecurr) && > + $fix) { > + $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*\Q$ms_addr\E\s*,\s*\Q$ms_val\E\s*,\s*ETH_ALEN\s*\)/eth_zero_addr($ms_addr)/; > + } elsif ($ms_val =~ /^(?:0xff|255)$/i && > + $ms_size =~ /^ETH_ALEN$/ && > + WARN("PREFER_ETH_ADDR", > + "Prefer eth_broadcast_addr() over memset() if the second address is 0xff\n" . $herecurr) && > + $fix) { > + $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*\Q$ms_addr\E\s*,\s*\Q$ms_val\E\s*,\s*ETH_ALEN\s*\)/eth_broadcast_addr($ms_addr)/; > } > } > > > Yes, this patch works smoothly. I'm not getting the false positives now. What is the next step? -- Kind Regards, Aya Saif El-yazal Mahfouz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/