Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592AbbBYGgk (ORCPT ); Wed, 25 Feb 2015 01:36:40 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:34221 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450AbbBYGgi (ORCPT ); Wed, 25 Feb 2015 01:36:38 -0500 Message-ID: <54ED6D71.9040703@plexistor.com> Date: Wed, 25 Feb 2015 08:36:33 +0200 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Dan Williams CC: Ingo Molnar , Ingo Molnar , Andy Lutomirski , Ross Zwisler , X86 ML , linux-kernel , "Roger C. Pao" , Thomas Gleixner , Linus Torvalds , linux-nvdimm , "H. Peter Anvin" , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Vivek Goyal Subject: Re: [PATCH 2/3 v4] resource: Add new flag IORESOURCE_MEM_WARN References: <54EB1D33.3050107@plexistor.com> <54EB206E.4010009@plexistor.com> <54EC38CA.6050607@plexistor.com> <20150224090742.GC19930@gmail.com> <54EC91F7.2030201@plexistor.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4109 Lines: 96 On 02/24/2015 07:04 PM, Dan Williams wrote: > On Tue, Feb 24, 2015 at 7:00 AM, Boaz Harrosh wrote: >> >> Resource providers set this flag if they want >> that request_region will print a warning in dmesg >> if this particular memory resource is locked by a driver. >> >> Thous acting as a Protocol Police about experimental >> devices that did not pass a committee approval. >> >> The Only user of this flag is x86/kernel/e820.c that >> wants to WARN about UNKNOWN memory types. >> >> NOTE: It would be preferred if I defined a general flag say >> IORESOURCE_WARN, where any kind of resource provider >> can WARN on use, but we have run out of flags in the >> 32bit long systems. So I defined a free bit from the >> resource specific flags for mem resources. This is >> why I need to check if this is a memory resource first >> so not to conflict with other resource specific flags. >> (Though actually no one is using this specific bit) >> >> CC: Thomas Gleixner >> CC: Ingo Molnar >> CC: "H. Peter Anvin" >> CC: x86@kernel.org >> CC: Dan Williams >> CC: Andrew Morton >> CC: Bjorn Helgaas >> CC: Vivek Goyal >> Signed-off-by: Boaz Harrosh >> --- >> arch/x86/kernel/e820.c | 3 +++ >> include/linux/ioport.h | 1 + >> kernel/resource.c | 9 ++++++++- >> 3 files changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c >> index 1a8a1c3..105bb37 100644 >> --- a/arch/x86/kernel/e820.c >> +++ b/arch/x86/kernel/e820.c >> @@ -961,6 +961,9 @@ void __init e820_reserve_resources(void) >> >> res->flags = IORESOURCE_MEM; >> >> + if (_is_unknown_type(e820.map[i].type)) >> + res->flags |= IORESOURCE_MEM_WARN; >> + >> /* >> * don't register the region that could be conflicted with >> * pci device BAR resource and insert them later in >> diff --git a/include/linux/ioport.h b/include/linux/ioport.h >> index 2c525022..f78972b 100644 >> --- a/include/linux/ioport.h >> +++ b/include/linux/ioport.h >> @@ -90,6 +90,7 @@ struct resource { >> #define IORESOURCE_MEM_32BIT (3<<3) >> #define IORESOURCE_MEM_SHADOWABLE (1<<5) /* dup: IORESOURCE_SHADOWABLE */ >> #define IORESOURCE_MEM_EXPANSIONROM (1<<6) >> +#define IORESOURCE_MEM_WARN (1<<7) /* WARN if requested by driver */ >> >> /* PnP I/O specific bits (IORESOURCE_BITS) */ >> #define IORESOURCE_IO_16BIT_ADDR (1<<0) >> diff --git a/kernel/resource.c b/kernel/resource.c >> index 19f2357..4bab16f 100644 >> --- a/kernel/resource.c >> +++ b/kernel/resource.c >> @@ -1075,8 +1075,15 @@ struct resource * __request_region(struct resource *parent, >> break; >> if (conflict != parent) { >> parent = conflict; >> - if (!(conflict->flags & IORESOURCE_BUSY)) >> + if (!(conflict->flags & IORESOURCE_BUSY)) { >> + if (unlikely( > > No need for unlikely(), this isn't a hot path. > >> + (resource_type(conflict) == IORESOURCE_MEM) >> + && (conflict->flags & IORESOURCE_MEM_WARN))) >> + pr_warn("request region with unknown memory type [mem %#010llx-%#010llx] %s\n", >> + conflict->start, conflict->end, >> + conflict->name); > > I think this should also dump the res->name to identify who is requesting it. > OK Will send a version 4 Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/