Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751682AbbBYGuj (ORCPT ); Wed, 25 Feb 2015 01:50:39 -0500 Received: from mga14.intel.com ([192.55.52.115]:15086 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750712AbbBYGui (ORCPT ); Wed, 25 Feb 2015 01:50:38 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,643,1418112000"; d="scan'208";a="683059260" Message-ID: <54ED70B9.9080101@intel.com> Date: Wed, 25 Feb 2015 08:50:33 +0200 From: Adrian Hunter User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Josh Boyer CC: Arnaldo Carvalho de Melo , "Linux-Kernel@Vger. Kernel. Org" , Jiri Olsa Subject: Re: [PATCH] perf tools: Fix pthread_attr_setaffinity_np build error References: <1424774766-24194-1-git-send-email-adrian.hunter@intel.com> <54EC8218.3060007@intel.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2536 Lines: 58 On 24/02/2015 4:31 p.m., Josh Boyer wrote: > On Tue, Feb 24, 2015 at 8:52 AM, Adrian Hunter wrote: >> On 24/02/15 15:32, Josh Boyer wrote: >>> On Tue, Feb 24, 2015 at 5:46 AM, Adrian Hunter wrote: >>>> Feature detection for pthread_attr_setaffinity_np was failing, >>>> producing this error: >>>> >>>> In file included from bench/futex-hash.c:17:0: >>>> bench/futex.h:73:19: error: conflicting types for 'pthread_attr_setaffinity_np' >>>> static inline int pthread_attr_setaffinity_np(pthread_attr_t *attr, >>>> ^ >>>> In file included from bench/futex.h:72:0, >>>> from bench/futex-hash.c:17: >>>> /usr/include/pthread.h:407:12: note: previous declaration of 'pthread_attr_setaffinity_np' was here >>>> extern int pthread_attr_setaffinity_np (pthread_attr_t *__attr, >>>> ^ >>>> make[3]: *** [bench/futex-hash.o] Error 1 >>>> make[2]: *** [bench] Error 2 >>>> make[2]: *** Waiting for unfinished jobs.... >>>> >>>> This was because compiling test-pthread-attr-setaffinity-np.c >>>> failed due to the function arguments: >>>> >>>> test-pthread-attr-setaffinity-np.c: In function 'main': >>>> test-pthread-attr-setaffinity-np.c:11:2: warning: null argument where non-null required (argument 3) [-Wnonnull] >>>> ret = pthread_attr_setaffinity_np(&thread_attr, 0, NULL); >>>> ^ >>>> So fix the arguments. >>> >>> Erm, I sent a different fix for this a while ago. It's queued in some >>> -tip tree. The feature test wasn't defining _GNU_SOURCE, which is >>> required for pthread_attr_setaffinity_np. Once that was set (passed >>> via -D in the Makefile), the feature test worked fine. >>> >>> Did you have to use your patch on top of the fix already queued? >> >> Yes. >> >> The error (warning + Werror) I got definitely seemed to be about the use of >> NULL as an argument. > > Hm, ok. Which compiler/glibc are you using? Curious that I'm not > seeing that issue. 4.8.2 You could also see if you have the __nonnull attribute in the header e.g. extern int pthread_attr_setaffinity_np (pthread_attr_t *__attr, size_t __cpusetsize, const cpu_set_t *__cpuset) __THROW __nonnull ((1, 3)); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/