Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752491AbbBYHUm (ORCPT ); Wed, 25 Feb 2015 02:20:42 -0500 Received: from mga09.intel.com ([134.134.136.24]:34351 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbbBYHUl (ORCPT ); Wed, 25 Feb 2015 02:20:41 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,643,1418112000"; d="asc'?scan'208";a="671266219" Message-ID: <1424848839.2553.34.camel@jtkirshe-mobl> Subject: Re: [E1000-devel] [PATCH] ixgbe: make VLAN filter conditional in SR-IOV case From: Jeff Kirsher To: Hiroshi Shimamoto Cc: "e1000-devel@lists.sourceforge.net" , "netdev@vger.kernel.org" , "Choi, Sy Jong" , Hayato Momma , "linux-kernel@vger.kernel.org" Date: Tue, 24 Feb 2015 23:20:39 -0800 In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD05E3F3CE@BPXM14GP.gisp.nec.co.jp> References: <7F861DC0615E0C47A872E6F3C5FCDDBD05D9D336@BPXM14GP.gisp.nec.co.jp> <1415898512.2454.26.camel@jtkirshe-mobl> <7F861DC0615E0C47A872E6F3C5FCDDBD05E3F3CE@BPXM14GP.gisp.nec.co.jp> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-rZaCBLGw/UKfkYU4r2+O" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3406 Lines: 89 --=-rZaCBLGw/UKfkYU4r2+O Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2015-02-25 at 00:51 +0000, Hiroshi Shimamoto wrote: > > Subject: Re: [E1000-devel] [PATCH] ixgbe: make VLAN filter > conditional in SR-IOV case > >=20 > > On Thu, 2014-11-13 at 08:28 +0000, Hiroshi Shimamoto wrote: > > > From: Hiroshi Shimamoto > > > > > > Disable hardware VLAN filtering if netdev->features VLAN flag is > > > dropped. > > > > > > In SR-IOV case, there is a use case which needs to disable VLAN > > > filter. > > > For example, we need to make a network function with VF in > virtualized > > > environment. That network function may be a software switch, a > router > > > or etc. It means that that network function will be an end point > which > > > terminates many VLANs. > > > > > > In the current implementation, VLAN filtering always be turned on > and > > > VF can receive only 63 VLANs. It means that only 63 VLANs can be > used > > > and it's not enough at all for building a virtual router. > > > > > > With this patch, if the user turns VLAN filtering off on the host, > VF > > > can receive every VLAN packet. > > > The behavior is changed only if VLAN filtering is turned off by > > > ethtool. > > > > > > Signed-off-by: Hiroshi Shimamoto > > > CC: Choi, Sy Jong > > > --- > > > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 ++++++++++ > > > drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 ++++ > > > 2 files changed, 14 insertions(+) > >=20 > > Thanks Hiroshi, I will add your patch to my queue. >=20 > How about this patch? > It hasn't been in your tree,. > Is there any issue? This patch was dropped for two reasons. First was Ben Hutchings issues with the patch needed to be addressed. Second, was due to a possible security hole which is why VLAN filtering was not disabled in SRIOV mode, where isolation is lost between VMs. If you want to continue going forward with this change, a warning message should be added, at least, warning the user of the possible security issues. --=-rZaCBLGw/UKfkYU4r2+O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJU7XfHAAoJEOVv75VaS+3OugsP/A1a9K4+xCe1/MOJxmHr6lsh CuqnXLaROBlQKZsW7GgAfq+U8ltgQaATKTptR0+Ot9TuBDmXNbhw9Ux6iM97iE2m MO2zchXFbmd/CJzFtCGy6fdpa+ja7vyHBsYfFUZwr5YSugwO88pElqEnKKR7uIcg xKTtNtuglag8q/9hJWFCEGHAa+YtdHGOhvkNFloM83Bg69EUJlvIet0H5fwom38k uijw0mMU/i8WiK59Poah76M/biW3ds3sDUJ9h9XSV1FnOzlxqHFQHhdGMVzu3SBq UCuoefUeAOQXVYe/7In8QtTS1vtg+U9YPmSjahZt+5rbg2F1+TIef1A9xeFr5qCz XOxiW11g6rTMhrtUI8+u7PIeEJtQh6j/G5tqNLxh2GHAwixl+kxgKVZDBB8BKrRm XjKhCWvy3YxHiz20Fa+By69zlP/+9DrW5XfV/ndxvMsoZ92+SZWYVpnDgIClBg6w NtoxWh/WZZodufTVfj7Rj0zoqf6U+fppYgM2VdRaw2Xm8COCZt84AWjK662d+/OT RGmGFnr3tmtZ+JACeVnxBma7dV4FezJ8fZKs7PrEoesGTOHdOs2ku3FeS8eeo6e4 ZIShKznGIzozZCjyjDpnETBqd6ySs3CRWZtTHC5LUPxydh+xPBuQ2DQJjstd541a 8X9hSoaufwz3xVhw73iH =mXPV -----END PGP SIGNATURE----- --=-rZaCBLGw/UKfkYU4r2+O-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/