Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753251AbbBYIl6 (ORCPT ); Wed, 25 Feb 2015 03:41:58 -0500 Received: from mga09.intel.com ([134.134.136.24]:14686 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169AbbBYIl4 (ORCPT ); Wed, 25 Feb 2015 03:41:56 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,643,1418112000"; d="scan'208";a="683100699" From: "Zheng, Lv" To: "Rafael J. Wysocki" , Scot Doyle CC: "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ACPI / EC: Remove non-standard log emphasis Thread-Topic: [PATCH] ACPI / EC: Remove non-standard log emphasis Thread-Index: AQHQSz+IJR5vaRf3sEKJVgdSifHzxp0BFOrw Date: Wed, 25 Feb 2015 08:41:33 +0000 Message-ID: <1AE640813FDE7649BE1B193DEA596E88026D8036@SHSMSX101.ccr.corp.intel.com> References: <7706896.L1jj2myRTu@vostro.rjw.lan> In-Reply-To: <7706896.L1jj2myRTu@vostro.rjw.lan> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t1P8g3CD025268 Content-Length: 2212 Lines: 59 Hi, > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Sent: Wednesday, February 18, 2015 2:19 PM > To: Scot Doyle > Cc: Zheng, Lv; linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] ACPI / EC: Remove non-standard log emphasis > > On Sunday, February 15, 2015 07:43:08 PM Scot Doyle wrote: > > Remove unusual pr_info() visual emphasis introduced in ad479e7f47ca > > "ACPI / EC: Introduce STARTED/STOPPED flags to replace BLOCKED flag". > > > > Signed-off-by: Scot Doyle > > Applied, thanks! > > > --- > > drivers/acpi/ec.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > > index 982b67f..857175e 100644 > > --- a/drivers/acpi/ec.c > > +++ b/drivers/acpi/ec.c > > @@ -680,7 +680,7 @@ static void acpi_ec_start(struct acpi_ec *ec, bool resuming) > > /* Enable GPE for event processing (SCI_EVT=1) */ > > if (!resuming) > > acpi_ec_submit_request(ec); > > - pr_info("+++++ EC started +++++\n"); > > + pr_info("EC started\n"); > > } > > spin_unlock_irqrestore(&ec->lock, flags); > > } > > @@ -712,7 +712,7 @@ static void acpi_ec_stop(struct acpi_ec *ec, bool suspending) > > acpi_ec_complete_request(ec); > > clear_bit(EC_FLAGS_STARTED, &ec->flags); > > clear_bit(EC_FLAGS_STOPPED, &ec->flags); > > - pr_info("+++++ EC stopped +++++\n"); > > + pr_info("EC stopped\n"); > > } > > spin_unlock_irqrestore(&ec->lock, flags); > > } > > I was using "+++++"/"#####"/"*****" to filter different EC log entries which makes debugging easier. And, if we changed this from pr_info into pr_debug, then we will have nothing in the suspend/resume logs for the EC device. While there are plenty of such log entries for each of other devices. So I really doubt what's the meaning of such a change. Could it improve anything or just make debugging more difficult for developers? Thanks and best regards -Lv > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?