Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592AbbBYJJj (ORCPT ); Wed, 25 Feb 2015 04:09:39 -0500 Received: from mail-we0-f175.google.com ([74.125.82.175]:35592 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293AbbBYJJg (ORCPT ); Wed, 25 Feb 2015 04:09:36 -0500 From: Gabriele Mazzotta To: Andrew Duggan Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires Subject: Re: [PATCH 3/3] HID: rmi: disable palm detect gesture when present Date: Wed, 25 Feb 2015 10:09:23 +0100 Message-ID: <18750379.9qMEg0zBWE@xps13> In-Reply-To: <1424828210-18972-3-git-send-email-aduggan@synaptics.com> References: <1424828210-18972-1-git-send-email-aduggan@synaptics.com> <1424828210-18972-3-git-send-email-aduggan@synaptics.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1389 Lines: 30 On Tuesday 24 February 2015 17:36:50 Andrew Duggan wrote: > A touchpad may have firmware based palm detection code enabled which > suppresses 2D data from being reported when the firmware believes a palm is > on the touchpad. This functionality is meant to be used in mouse mode without > a driver. When a driver is present, the driver can do a better job of > determining if a contact is a palm. If this gesture is enabled on a touchpad > operating in rmi mode then the firmware will not properly clear the palm detect > interrupt, causing the touchpad to interrupt indefinately. This patch disables > the palm detect gesture when the touchpad is operating in rmi mode. > > Signed-off-by: Andrew Duggan > --- > Hi Gabriele, > > Can you test this patch on your system to confirm that it fixes your issue? > I was able to test the other two patches so I can confirm that the write > fuction works. But, I don't have a touchpad with the palm detect gesture > enabled so it would be good to double check that I have the right address and > mask. > > Andrew I tested it and confirm that it's working. Thanks. Gabriele -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/