Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753377AbbBYKbm (ORCPT ); Wed, 25 Feb 2015 05:31:42 -0500 Received: from mail-we0-f173.google.com ([74.125.82.173]:45958 "EHLO mail-we0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752643AbbBYKbi (ORCPT ); Wed, 25 Feb 2015 05:31:38 -0500 Date: Wed, 25 Feb 2015 11:31:32 +0100 From: Ingo Molnar To: Matt Fleming Cc: Yinghai Lu , Thomas Gleixner , "H. Peter Anvin" , Ingo Molnar , Jonathan Corbet , Matt Fleming , Kees Cook , Junjie Mao , linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86, boot: Allow 64bit EFI kernel to be loaded above 4G Message-ID: <20150225103132.GB554@gmail.com> References: <1424663028-13066-1-git-send-email-yinghai@kernel.org> <20150224215501.GB9758@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150224215501.GB9758@codeblueprint.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1355 Lines: 36 * Matt Fleming wrote: > On Sun, 22 Feb, at 07:43:48PM, Yinghai Lu wrote: > > Index: linux-2.6/arch/x86/boot/header.S > > =================================================================== > > --- linux-2.6.orig/arch/x86/boot/header.S > > +++ linux-2.6/arch/x86/boot/header.S > > @@ -301,7 +301,7 @@ _start: > > # Part 2 of the header, from the old setup.S > > > > .ascii "HdrS" # header signature > > - .word 0x020d # header version number (>= 0x0105) > > + .word 0x020e # header version number (>= 0x0105) > > # or else old loadlin-1.5 will fail) > > .globl realmode_swtch > > realmode_swtch: .word 0, 0 # default_switch, SETUPSEG > > @@ -449,6 +449,7 @@ pref_address: .quad LOAD_PHYSICAL_ADDR > > #endif > > init_size: .long INIT_SIZE # kernel initialization size > > handover_offset: .long 0 # Filled in by build.c > > +ext_code32_start: .long 0 # werid one! > > How about a comment like, "# Upper 32-bits of code32_start" ? Also, in the Linux kernel we should not go about inventing new English words like 'werid', right? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/