Message-ID: <54EDADD6.5070404@huawei.com>
Date: Wed, 25 Feb 2015 19:11:18 +0800
From: Wang Nan <wangnan0@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1
MIME-Version: 1.0
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
CC: <linux@arm.linux.org.uk>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <hpa@zytor.com>, <rostedt@goodmis.org>, <ananth@in.ibm.com>,
        <anil.s.keshavamurthy@intel.com>, <davem@davemloft.net>,
        <luto@amacapital.net>, <keescook@chromium.org>, <oleg@redhat.com>,
        <dave.long@linaro.org>, <tixy@linaro.org>, <nico@linaro.org>,
        <yalin.wang2010@gmail.com>, <catalin.marinas@arm.com>,
        <Yalin.Wang@sonymobile.com>, <mark.rutland@arm.com>,
        <dave.hansen@linux.intel.com>, <jkenisto@us.ibm.com>,
        <anton@samba.org>, <stefani@seibold.net>, <JBeulich@suse.com>,
        <akpm@linux-foundation.org>, <rusty@rustcorp.com.au>,
        <peterz@infradead.org>, <prarit@redhat.com>, <fabf@skynet.be>,
        <hannes@cmpxchg.org>, <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <lizefan@huawei.com>,
        "yrl.pp-manager.tt@hitachi.com" <yrl.pp-manager.tt@hitachi.com>
Subject: Re: [RFC PATCH v3 00/26] Early kprobe: enable kprobes at very early
 booting stage.
References: <1423805941-61407-1-git-send-email-wangnan0@huawei.com> <54E6B139.20909@hitachi.com>
In-Reply-To: <54E6B139.20909@hitachi.com>
Content-Type: text/plain; charset="ISO-2022-JP"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1856
Lines: 46

On 2015/2/20 11:59, Masami Hiramatsu wrote:
> Hi,
> 
> Sorry for replying late.
> 
> (2015/02/13 14:39), Wang Nan wrote:
>> I fell very sorry for people who reviewed my v2 patch series yesterday
>> at https://lkml.org/lkml/2015/2/12/234 because I didn't provide enough
>> information in commit log. This v3 patch series add those missing
>> commit messages. There are also 2 small fix based on v2:
>>
>>  1. Fixes ftrace_sort_mcount_area. Original patch doesn't work for module.
>>  2. Wraps setting of kprobes_initialized in stop_machine() context.
> 
> From the viewpoint of the maintenance, it seems over-engineered and
> not general implementation. Please reconsider just initializing breakpoint
> handler in earlier stage. Since those exceptions may happen anywhere,
> those trap handlers setup very early stage. E.g. on x86, setup_arch()
> setup early_trap_init() at beginning. So we just need to initialize
> kprobes earlier.

I tried as your suggestion. For x86, int3 handler doesn't work correctly until
trap_init(). I don't have enough time to look into this problem today (and I don't
familiar with x86 architecture). Could you please have a look on it?

Thank you.

> I think this is almost enough for debugging, and very general because
> we don't need optprobe for porting to other arch.
> 
> And for ftrace-based kprobe, we can just put breakpoint on mcount call at
> beginning. ftrace will need to check and keep it when replacing mcount-call
> with nop. Afterward, we can cleanly update those kprobes with ftrace-based
> kprobe.
> 
> So, please start with smaller changes.
> 
> Thank you,
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/