Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753328AbbBYLW5 (ORCPT ); Wed, 25 Feb 2015 06:22:57 -0500 Received: from mail.skyhub.de ([78.46.96.112]:57678 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbbBYLWz (ORCPT ); Wed, 25 Feb 2015 06:22:55 -0500 Date: Wed, 25 Feb 2015 12:21:53 +0100 From: Borislav Petkov To: Vikas Shivappa Cc: Vikas Shivappa , linux-kernel@vger.kernel.org, matt.fleming@intel.com, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org, peterz@infradead.org, will.auld@intel.com, dave.hansen@intel.com, andi.kleen@intel.com, tony.luck@intel.com, kanaka.d.juvva@intel.com Subject: Re: [PATCH 1/7] x86/intel_rdt: Intel Cache Allocation Technology detection Message-ID: <20150225112153.GB3226@pd.tnic> References: <1424819804-4082-1-git-send-email-vikas.shivappa@linux.intel.com> <1424819804-4082-2-git-send-email-vikas.shivappa@linux.intel.com> <20150224234334.GB3706@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1321 Lines: 45 On Tue, Feb 24, 2015 at 04:42:10PM -0800, Vikas Shivappa wrote: > >>+ > >>+ pr_info("cbmlength:%u,Closs: %u\n", cbm_len, maxid); > > > >This text message needs to be much more user-friendly if it is going out > >to the console unconditionally. > > > > bit mask lengh: number of CLOSids: ? . it should print with the module name > as well which should help understand what it is for. Right, if I haven't read the SDM on RDT, I still don't understand what those mean. What is the need for that message at all, what is it telling me? Can you show an example from a machine with RDT and explain what it is good for? > >>+config CGROUP_RDT > >>+ bool "Resource Director Technology cgroup subsystem" > >>+ depends on X86_64 > > > >depends on X86_64 && CPU_SUP_INTEL > > > >Also, this should probably also depend on CGROUP-something or so > >AFAICT... > > This is with in the if CGROUPS Right, but you still need the CPU_SUP_INTEL dependency as !Intel x86 doesn't need that code built. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/