Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753459AbbBYMJL (ORCPT ); Wed, 25 Feb 2015 07:09:11 -0500 Received: from mail-qg0-f45.google.com ([209.85.192.45]:61714 "EHLO mail-qg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752545AbbBYMJH (ORCPT ); Wed, 25 Feb 2015 07:09:07 -0500 MIME-Version: 1.0 In-Reply-To: <20150225100330.0ef63a95@amdc2363> References: <1424753815-15113-1-git-send-email-cw00.choi@samsung.com> <1424753815-15113-2-git-send-email-cw00.choi@samsung.com> <20150225100330.0ef63a95@amdc2363> Date: Wed, 25 Feb 2015 17:39:06 +0530 Message-ID: Subject: Re: [PATCH 1/2] thermal: exynos: Fix wrong control of power down detection mode for Exynos7 From: Abhilash Kesavan To: Lukasz Majewski Cc: Chanwoo Choi , Zhang Rui , Eduardo Valentin , Kukjin Kim , Bartlomiej Zolnierkiewicz , Amit Kachhap , inki.dae@samsung.com, Kyungmin Park , "linux-pm@vger.kernel.org" , linux-arm-kernel , linux-samsung-soc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2268 Lines: 62 Hi Lukasz, On Wed, Feb 25, 2015 at 2:33 PM, Lukasz Majewski wrote: > Hi Abhilash, > >> This patch fixes the wrong control of PD_DET_EN (power down detection >> mode) for Exynos7 because exynos7_tmu_control() always enables the >> power down detection mode regardless 'on' parameter. >> >> Cc: Zhang Rui >> Cc: Eduardo Valentin >> Signed-off-by: Chanwoo Choi >> --- >> drivers/thermal/samsung/exynos_tmu.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/thermal/samsung/exynos_tmu.c >> b/drivers/thermal/samsung/exynos_tmu.c index 933cd80..a60f527 100644 >> --- a/drivers/thermal/samsung/exynos_tmu.c >> +++ b/drivers/thermal/samsung/exynos_tmu.c >> @@ -682,6 +682,7 @@ static void exynos7_tmu_control(struct >> platform_device *pdev, bool on) >> if (on) { >> con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT); >> + con |= (1 << EXYNOS7_PD_DET_EN_SHIFT); >> interrupt_en = >> (of_thermal_is_trip_valid(tz, 7) >> << EXYNOS7_TMU_INTEN_RISE7_SHIFT) | >> @@ -704,9 +705,9 @@ static void exynos7_tmu_control(struct >> platform_device *pdev, bool on) interrupt_en << >> EXYNOS_TMU_INTEN_FALL0_SHIFT; } else { >> con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT); >> + con &= ~(1 << EXYNOS7_PD_DET_EN_SHIFT); >> interrupt_en = 0; /* Disable all interrupts */ >> } >> - con |= 1 << EXYNOS7_PD_DET_EN_SHIFT; >> >> writel(interrupt_en, data->base + EXYNOS7_TMU_REG_INTEN); >> writel(con, data->base + EXYNOS_TMU_REG_CONTROL); > > Could you test this patch if it isn't introducing any regression on your > HW? The patch does not cause any regression on exynos7 and seems logically correct. Tested-by: Abhilash Kesavan Regards, Abhilash > > -- > Best regards, > > Lukasz Majewski > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/