Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbbBYMZX (ORCPT ); Wed, 25 Feb 2015 07:25:23 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:51138 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbbBYMZU convert rfc822-to-8bit (ORCPT ); Wed, 25 Feb 2015 07:25:20 -0500 X-AuditID: cbfee61b-f79d76d0000024d6-59-54edbf2ebc1b Date: Wed, 25 Feb 2015 13:25:08 +0100 From: Lukasz Majewski To: Eduardo Valentin Cc: l.majewski@majess.pl, "linux-pm@vger.kernel.org" , linux-arm-kernel , linux-samsung-soc , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] thermal: exynos: Fix wrong control of power down detection mode for Exynos7 Message-id: <20150225132508.5143c9cf@amdc2363> In-reply-to: References: <1424753815-15113-1-git-send-email-cw00.choi@samsung.com> <1424753815-15113-2-git-send-email-cw00.choi@samsung.com> <20150225100330.0ef63a95@amdc2363> Organization: SPRC Poland X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 8BIT X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t9jAV29/W9DDNZvUbKYf+Uaq8WbR9wW mx4DGZd3zWGz+Nx7hNFixvl9TA5sHjtn3WX32Lyk3mPdtLfMHp83yQWwRHHZpKTmZJalFunb JXBlrPz4lrXginDFxt6rrA2M//i6GDk5JARMJLadncQCYYtJXLi3nq2LkYtDSGARo8TClz+Z QBJCAr8YJXqexYPYLAKqEjPmXWEHsdkE9CQ+330KViMioCVx4tJ2JpBmZoE2Jomt0/YygiSE BdIkTnS9YAaxeYEaHr98ygpicwoES5ze2sQOse0to8TdSb/BEvwCkhLt/34wQ5xkJ3Hu0wZ2 iGZBiR+T74Gdygy0bfO2JlYIW1viybsLrBMYBWchKZuFpGwWkrIFjMyrGEVTC5ILipPSc430 ihNzi0vz0vWS83M3MYID/Zn0DsZVDRaHGAU4GJV4eBOF34QIsSaWFVfmHmKU4GBWEuH9tfVt iBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXFeJfu2ECGB9MSS1OzU1ILUIpgsEwenVAPjpNulGxm2 Wu7j+LJXcGnUpKf/pc0Wt6360Lhl18Fnou/mpTArvb+469U/bTuhu4kHj+0+9+RiTNwWmfC8 qEXr2A3KUyQ7Q8WWVxnnrZ8yi+lmnUbymZ+vD+mGOijN3Gb3472mq/Gm9Yprd24J7nX+/SBw 0uor8d1CTt0vshhl4/2uaB23YU77o8RSnJFoqMVcVJwIAPwbKs1wAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2658 Lines: 81 Hi Eduardo, > Hi Lukasz, > > On Wed, Feb 25, 2015 at 2:33 PM, Lukasz Majewski > wrote: > > Hi Abhilash, > > > >> This patch fixes the wrong control of PD_DET_EN (power down > >> detection mode) for Exynos7 because exynos7_tmu_control() always > >> enables the power down detection mode regardless 'on' parameter. > >> > >> Cc: Zhang Rui > >> Cc: Eduardo Valentin > >> Signed-off-by: Chanwoo Choi > >> --- > >> drivers/thermal/samsung/exynos_tmu.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/thermal/samsung/exynos_tmu.c > >> b/drivers/thermal/samsung/exynos_tmu.c index 933cd80..a60f527 > >> 100644 --- a/drivers/thermal/samsung/exynos_tmu.c > >> +++ b/drivers/thermal/samsung/exynos_tmu.c > >> @@ -682,6 +682,7 @@ static void exynos7_tmu_control(struct > >> platform_device *pdev, bool on) > >> if (on) { > >> con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT); > >> + con |= (1 << EXYNOS7_PD_DET_EN_SHIFT); > >> interrupt_en = > >> (of_thermal_is_trip_valid(tz, 7) > >> << EXYNOS7_TMU_INTEN_RISE7_SHIFT) | > >> @@ -704,9 +705,9 @@ static void exynos7_tmu_control(struct > >> platform_device *pdev, bool on) interrupt_en << > >> EXYNOS_TMU_INTEN_FALL0_SHIFT; } else { > >> con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT); > >> + con &= ~(1 << EXYNOS7_PD_DET_EN_SHIFT); > >> interrupt_en = 0; /* Disable all interrupts */ > >> } > >> - con |= 1 << EXYNOS7_PD_DET_EN_SHIFT; > >> > >> writel(interrupt_en, data->base + EXYNOS7_TMU_REG_INTEN); > >> writel(con, data->base + EXYNOS_TMU_REG_CONTROL); > > > > Could you test this patch if it isn't introducing any regression on > > your HW? > > The patch does not cause any regression on exynos7 and seems > logically correct. > > Tested-by: Abhilash Kesavan > Eduardo, it is up to you if you prefer to take this fix directly or via the new thermal-samsung tree ? >From when shall I regard myself as a maintainer? :-) > > Regards, > Abhilash > > > > -- > > Best regards, > > > > Lukasz Majewski > > > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/