Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752856AbbBYPDl (ORCPT ); Wed, 25 Feb 2015 10:03:41 -0500 Received: from mx1.scotdoyle.com ([23.226.141.211]:36825 "EHLO mx1.scotdoyle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751497AbbBYPDk (ORCPT ); Wed, 25 Feb 2015 10:03:40 -0500 Date: Wed, 25 Feb 2015 15:01:08 +0000 (UTC) From: Scot Doyle To: "Zheng, Lv" cc: "Rafael J. Wysocki" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ACPI / EC: Remove non-standard log emphasis In-Reply-To: <1AE640813FDE7649BE1B193DEA596E88026D8057@SHSMSX101.ccr.corp.intel.com> Message-ID: References: <7706896.L1jj2myRTu@vostro.rjw.lan> <1AE640813FDE7649BE1B193DEA596E88026D8057@SHSMSX101.ccr.corp.intel.com> User-Agent: Alpine 2.11 (LNX 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 32 On Wed, 25 Feb 2015, Zheng, Lv wrote: ... > > I was using "+++++"/"#####"/"*****" to filter different EC log entries which makes debugging easier. > > And, if we changed this from pr_info into pr_debug, then we will have nothing in the suspend/resume logs for the EC device. > > While there are plenty of such log entries for each of other devices. > > So I really doubt what's the meaning of such a change. > > Could it improve anything or just make debugging more difficult for developers? > > IMO, it's better to introduce such kind of code in the head of ec.c: > > #ifdef DEBUG_FILTER > #define EC_LOG_DEV "+++++" > #define EC_LOG_CMD "*****" > #define EC_LOG_EVT "#####" > ... > #else > #define EC_LOG_DEV > #define EC_LOG_CMD > #define EC_LOG_EVT > #endif > > And wrap the pr_info, pr_debug using filter enabled new macros - ec_info, ec_debug so that we won't see the filters in the normal dmesg output and the filters are still available for the developers. > > Thanks and best regards > -Lv I agree, would you be willing to submit it? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/