Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753284AbbBYPJI (ORCPT ); Wed, 25 Feb 2015 10:09:08 -0500 Received: from mail-wg0-f51.google.com ([74.125.82.51]:41165 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752549AbbBYPJG (ORCPT ); Wed, 25 Feb 2015 10:09:06 -0500 Date: Wed, 25 Feb 2015 15:08:53 +0000 From: Lee Jones To: Rob Herring Cc: Peter Griffin , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Srinivas Kandagatla , Maxime Coquelin , patrice.chotard@st.com, Kishon Vijay Abraham I , Felipe Balbi , "devicetree@vger.kernel.org" Subject: Re: [PATCH 2/6] ahci: st: Update the DT example for how to obtain the PHY. Message-ID: <20150225150853.GC5132@x1> References: <1424871377-1795-1-git-send-email-peter.griffin@linaro.org> <1424871377-1795-3-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1031 Lines: 27 On Wed, 25 Feb 2015, Rob Herring wrote: > On Wed, Feb 25, 2015 at 7:36 AM, Peter Griffin wrote: > > The example is wrong in that the phys property should take a > > phandle to the phy port. > > > > Also with the changing over to generic PHY type constants we also > > update this as well. > > > > Signed-off-by: Peter Griffin > > We seem to have a variety of ways to describe phy's with SATA > controllers. Some consistency would have been nice. This way is the correct way. I worked closely with Kishon to get it right. He even used this code as an example at ELC, Dusseldorf. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/