Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753336AbbBYPMo (ORCPT ); Wed, 25 Feb 2015 10:12:44 -0500 Received: from mail-wi0-f182.google.com ([209.85.212.182]:55526 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbbBYPMm (ORCPT ); Wed, 25 Feb 2015 10:12:42 -0500 Date: Wed, 25 Feb 2015 15:12:29 +0000 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, kishon@ti.com, balbi@ti.com, devicetree@vger.kernel.org Subject: Re: [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node. Message-ID: <20150225151229.GE5132@x1> References: <1424871377-1795-1-git-send-email-peter.griffin@linaro.org> <1424871377-1795-5-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1424871377-1795-5-git-send-email-peter.griffin@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2307 Lines: 72 On Wed, 25 Feb 2015, Peter Griffin wrote: > Now that both usb2 and usb3 phy drivers, and also the ST dwc3 glue code > are all present upstream, we can add the dwc3 DT node and have a working > usb3 controller on stih407-b2120 and stih410-b2020. > > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > index 186412d..18ff5a5 100644 > --- a/arch/arm/boot/dts/stih407-family.dtsi > +++ b/arch/arm/boot/dts/stih407-family.dtsi > @@ -7,6 +7,7 @@ > * publishhed by the Free Software Foundation. > */ > #include "stih407-pinctrl.dtsi" > +#include > #include > / { > #address-cells = <1>; > @@ -336,5 +337,30 @@ > resets = <&softreset STIH407_MIPHY2_SOFTRESET>; > }; > }; > + > + st_dwc3: dwc3@8f94000 { > + compatible = "st,stih407-dwc3"; > + reg = <0x08f94000 0x1000>, <0x110 0x4>; > + reg-names = "reg-glue", "syscfg-reg"; > + st,syscfg = <&syscfg_core>; > + resets = <&powerdown STIH407_USB3_POWERDOWN>, > + <&softreset STIH407_MIPHY2_SOFTRESET>; > + reset-names = "powerdown", > + "softreset"; Nit: What's the purpose of having these on separate lines? Apart from that, it looks good: Acked-by: Lee Jones > + #address-cells = <1>; > + #size-cells = <1>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb3>; > + ranges; > + > + dwc3: dwc3@9900000 { > + compatible = "snps,dwc3"; > + reg = <0x09900000 0x100000>; > + interrupts = ; > + dr_mode = "host"; > + phy-names = "usb2-phy", "usb3-phy"; > + phys = <&usb2_picophy0>, <&phy_port2 PHY_TYPE_USB3>; > + }; > + }; > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/