Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753430AbbBYPNy (ORCPT ); Wed, 25 Feb 2015 10:13:54 -0500 Received: from mail-we0-f180.google.com ([74.125.82.180]:41655 "EHLO mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753032AbbBYPNw (ORCPT ); Wed, 25 Feb 2015 10:13:52 -0500 Date: Wed, 25 Feb 2015 15:13:40 +0000 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, kishon@ti.com, balbi@ti.com, devicetree@vger.kernel.org Subject: Re: [PATCH 2/6] ahci: st: Update the DT example for how to obtain the PHY. Message-ID: <20150225151340.GG5132@x1> References: <1424871377-1795-1-git-send-email-peter.griffin@linaro.org> <1424871377-1795-3-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1424871377-1795-3-git-send-email-peter.griffin@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1914 Lines: 48 On Wed, 25 Feb 2015, Peter Griffin wrote: > The example is wrong in that the phys property should take a > phandle to the phy port. > > Also with the changing over to generic PHY type constants we also > update this as well. > > Signed-off-by: Peter Griffin > --- > Documentation/devicetree/bindings/ata/ahci-st.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Lee Jones > diff --git a/Documentation/devicetree/bindings/ata/ahci-st.txt b/Documentation/devicetree/bindings/ata/ahci-st.txt > index 0574a77..1331202 100644 > --- a/Documentation/devicetree/bindings/ata/ahci-st.txt > +++ b/Documentation/devicetree/bindings/ata/ahci-st.txt > @@ -11,7 +11,7 @@ Required properties: > - reset-names : Associated names must be; "pwr-dwn" and "sw-rst" > - clocks : The phandle for the clock > - clock-names : Associated name must be; "ahci_clk" > - - phys : The phandle for the PHY device > + - phys : The phandle for the PHY port > - phy-names : Associated name must be; "ahci_phy" > > Example: > @@ -21,7 +21,7 @@ Example: > reg = <0xfe380000 0x1000>; > interrupts = ; > interrupt-names = "hostc"; > - phys = <&miphy365x_phy MIPHY_PORT_0 MIPHY_TYPE_SATA>; > + phys = <&phy_port0 PHY_TYPE_SATA>; > phy-names = "ahci_phy"; > resets = <&powerdown STIH416_SATA0_POWERDOWN>, > <&softreset STIH416_SATA0_SOFTRESET>; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/