Date: Wed, 25 Feb 2015 11:01:29 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] x86: entry.S: tidy up several suboptimal insns
Message-ID: <20150225110129.5d099cd8@gandalf.local.home>
In-Reply-To: <CAK1hOcNgDk7oXx0UqzYJNhxHCdauKw8n=YgHJ-kHj7wUMhvLKw@mail.gmail.com>
References: <1424803895-4420-1-git-send-email-dvlasenk@redhat.com>
	<CALCETrVretXX1Wgx9TNQH67XH=M6fGA+L+7agyp0Fm8503Ey9w@mail.gmail.com>
	<54ED00B5.3020203@zytor.com>
	<20150225092043.GB16165@gmail.com>
	<20150225094312.2cfff453@gandalf.local.home>
	<CAK1hOcNgDk7oXx0UqzYJNhxHCdauKw8n=YgHJ-kHj7wUMhvLKw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1151
Lines: 29

On Wed, 25 Feb 2015 16:40:49 +0100
Denys Vlasenko <vda.linux@googlemail.com> wrote:

> >> The downside would be that if we ever grow past 1024
> >> syscall entries we'll be in trouble if new userspace calls
> >> syscall 513 on an old kernel and gets syscall 1.
> >
> > What if we test against ~0x3ff and jump to sys_ni if anything is set.
> > This would still work with new userspace calls on older kernels.
> 
> That would require a branch insn. The whole idea of masking
> was merely to avoid that branch. If you need a branch,
> then you can as well just retain current code.

I'm just curious, do all these micro optimizations have any real impact
on real use cases?

That is, if we are going to make the system less robust, shouldn't we
show that it has real benefit?

And yes, I consider user space passing in a system call of 0x401 and
having it work the same as 0x1 as being less robust.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/