Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752959AbbBYS30 (ORCPT ); Wed, 25 Feb 2015 13:29:26 -0500 Received: from mail-pd0-f174.google.com ([209.85.192.174]:35808 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbbBYS3Y (ORCPT ); Wed, 25 Feb 2015 13:29:24 -0500 Date: Wed, 25 Feb 2015 14:29:18 -0400 From: Eduardo Valentin To: Guenter Roeck Cc: Lukasz Majewski , Kamil Debski , Jean Delvare , Kukjin Kim , lm-sensors@lm-sensors.org, Linux PM list , "linux-samsung-soc@vger.kernel.org" , devicetree@vger.kernel.org, Lukasz Majewski , Kukjin Kim , linux-kernel@vger.kernel.org, Sjoerd Simons , Abhilash Kesavan , Abhilash Kesavan Subject: Re: [PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Message-ID: <20150225182917.GB2306@developer.amazonguestwifi.org> References: <1418897591-18332-1-git-send-email-l.majewski@samsung.com> <1424878462-15511-1-git-send-email-l.majewski@samsung.com> <20150225171820.GA2400@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dc+cDN39EJAMEtIO" Content-Disposition: inline In-Reply-To: <20150225171820.GA2400@roeck-us.net> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3241 Lines: 94 --dc+cDN39EJAMEtIO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Guenter, On Wed, Feb 25, 2015 at 09:18:20AM -0800, Guenter Roeck wrote: > On Wed, Feb 25, 2015 at 04:34:16PM +0100, Lukasz Majewski wrote: > > Presented patches add support for Odroid's U3 optional CPU FAN, which u= ses PWM > > subsystem for low level control. > >=20 > > After successful probe it registers itself as a cooling device for ther= mal > > subsystem. > >=20 > > This driver also supports devices without DTS specified. > >=20 > > To provide correct functionality, new properties to device tree descrip= tion for > > Exynos4412 and in particular Odroid U3 have been added. > >=20 > > Those patches were tested at Exynos4412 - Odroid U3 board. > >=20 > > Patches were applied on: > > linux-soc-thermal/fixes branch (Linux v4.0-rc1) > > SHA1: b71d399c7f2fe06b60b96155ec0b9ae167334e4a > >=20 > > Kamil Debski (1): > > ARM: dts: Add pwm-fan node to the Odroid-U3 board > >=20 > > Lukasz Majewski (5): > > Documentation: dts: Documentation entry to explain how to use PWM FAN > > as a cooling device > > ARM: dts: Add properties to use pwm-fan device as a cooling device in > > Odroid U3 > > hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty > > cycle > > hwmon: pwm-fan: Read PWM FAN configuration from device tree > > hwmon: pwm-fan: Code for using PWM FAN as a cooling device > >=20 > > .../devicetree/bindings/hwmon/pwm-fan.txt | 25 +++- > > arch/arm/boot/dts/exynos4.dtsi | 2 +- > > arch/arm/boot/dts/exynos4412-odroidu3.dts | 43 ++++++ > > drivers/hwmon/pwm-fan.c | 166 +++++++++++++= ++++++-- > > 4 files changed, 220 insertions(+), 16 deletions(-) > >=20 > For the series: >=20 > Acked-by: Guenter Roeck >=20 > Should I take it through hwmon ? Might make sense given the majority > of the changes is in hwmon code. I believe the series should go via your tree, yes. I had only minor comments in the code added for the cooling device code, as it lacks the unregistration call in the .remove callback.=20 Also, the DTS changes may generate conflicts with platform code. Lukasz may probably ask Kukjin Kim to add them via the samsung tree. BR, Eduardo Valentin >=20 > Thanks, > Guenter --dc+cDN39EJAMEtIO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJU7hR1AAoJEMLUO4d9pOJWX7YH/0AzszI7w0H1frCpqPJsXquO KpIe4Y1HMvlWtagEzrHvF2SZxchatenIWoEksAvWvny/gqD8LkgS9JyRt5b5SBSt spm4Ossrt5DE3IyxIVZyShloL/m4XTSF68ufhkIFzveTRQaftoY4P+ar/D4v5OUM jyQwJZzP5/CXir9SWhAeVkfcvuUTya/OyG8fXjgvdxKMyOjF4MHR5BvQ4aDfz/gv QGNj3angjL9RvLsGkVg5w+QwUcS5c8R0lE28gsfdUKcnqnw4M8KI1O0H1nUiEC3u zXe2XMOFr3o7NXmxZgQ6Or1ArCtBvG5uWImMmM8klzslaM/vL8y6Z8vL4TmwAcw= =6xG6 -----END PGP SIGNATURE----- --dc+cDN39EJAMEtIO-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/