Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753440AbbBYSnx (ORCPT ); Wed, 25 Feb 2015 13:43:53 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:57247 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753006AbbBYSnu (ORCPT ); Wed, 25 Feb 2015 13:43:50 -0500 Date: Wed, 25 Feb 2015 10:42:33 -0800 From: Guenter Roeck To: Eduardo Valentin Cc: Lukasz Majewski , Kamil Debski , Jean Delvare , Kukjin Kim , lm-sensors@lm-sensors.org, Linux PM list , "linux-samsung-soc@vger.kernel.org" , devicetree@vger.kernel.org, Lukasz Majewski , Kukjin Kim , linux-kernel@vger.kernel.org, Sjoerd Simons , Abhilash Kesavan , Abhilash Kesavan Subject: Re: [PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Message-ID: <20150225184233.GB4231@roeck-us.net> References: <1418897591-18332-1-git-send-email-l.majewski@samsung.com> <1424878462-15511-1-git-send-email-l.majewski@samsung.com> <20150225171820.GA2400@roeck-us.net> <20150225182917.GB2306@developer.amazonguestwifi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150225182917.GB2306@developer.amazonguestwifi.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020206.54EE17E5.0284,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 22 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2679 Lines: 64 On Wed, Feb 25, 2015 at 02:29:18PM -0400, Eduardo Valentin wrote: > Guenter, > > On Wed, Feb 25, 2015 at 09:18:20AM -0800, Guenter Roeck wrote: > > On Wed, Feb 25, 2015 at 04:34:16PM +0100, Lukasz Majewski wrote: > > > Presented patches add support for Odroid's U3 optional CPU FAN, which uses PWM > > > subsystem for low level control. > > > > > > After successful probe it registers itself as a cooling device for thermal > > > subsystem. > > > > > > This driver also supports devices without DTS specified. > > > > > > To provide correct functionality, new properties to device tree description for > > > Exynos4412 and in particular Odroid U3 have been added. > > > > > > Those patches were tested at Exynos4412 - Odroid U3 board. > > > > > > Patches were applied on: > > > linux-soc-thermal/fixes branch (Linux v4.0-rc1) > > > SHA1: b71d399c7f2fe06b60b96155ec0b9ae167334e4a > > > > > > Kamil Debski (1): > > > ARM: dts: Add pwm-fan node to the Odroid-U3 board > > > > > > Lukasz Majewski (5): > > > Documentation: dts: Documentation entry to explain how to use PWM FAN > > > as a cooling device > > > ARM: dts: Add properties to use pwm-fan device as a cooling device in > > > Odroid U3 > > > hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty > > > cycle > > > hwmon: pwm-fan: Read PWM FAN configuration from device tree > > > hwmon: pwm-fan: Code for using PWM FAN as a cooling device > > > > > > .../devicetree/bindings/hwmon/pwm-fan.txt | 25 +++- > > > arch/arm/boot/dts/exynos4.dtsi | 2 +- > > > arch/arm/boot/dts/exynos4412-odroidu3.dts | 43 ++++++ > > > drivers/hwmon/pwm-fan.c | 166 +++++++++++++++++++-- > > > 4 files changed, 220 insertions(+), 16 deletions(-) > > > > > For the series: > > > > Acked-by: Guenter Roeck > > > > Should I take it through hwmon ? Might make sense given the majority > > of the changes is in hwmon code. > > I believe the series should go via your tree, yes. I had only minor > comments in the code added for the cooling device code, as it lacks the > unregistration call in the .remove callback. > > Also, the DTS changes may generate conflicts with platform code. Lukasz > may probably ask Kukjin Kim to add them via the samsung tree. > Ok, I'll wait for the updated patch and then add the hwmon parts to hwmon-next. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/