Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753372AbbBYSr6 (ORCPT ); Wed, 25 Feb 2015 13:47:58 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:60721 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752847AbbBYSry (ORCPT ); Wed, 25 Feb 2015 13:47:54 -0500 Date: Wed, 25 Feb 2015 13:47:43 -0500 (EST) Message-Id: <20150225.134743.267148874428657838.davem@davemloft.net> To: ameenali023@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] net/core/dev.c : Race condition in net_tx_action. From: David Miller In-Reply-To: <1424886659-3641-1-git-send-email-ameenali023@gmail.com> References: <1424886659-3641-1-git-send-email-ameenali023@gmail.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Wed, 25 Feb 2015 10:47:54 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 631 Lines: 16 From: Ameen Ali Date: Wed, 25 Feb 2015 19:50:59 +0200 > @@ -3413,7 +3413,7 @@ EXPORT_SYMBOL(netif_rx_ni); > > static void net_tx_action(struct softirq_action *h) > { > - struct softnet_data *sd = this_cpu_ptr(&softnet_data); > + volatile struct softnet_data *sd = &__get_cpu_var(softnet_data); volatile is never an appropriate solution to a race condition -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/