Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537AbbBYTNN (ORCPT ); Wed, 25 Feb 2015 14:13:13 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:39782 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbbBYTNK (ORCPT ); Wed, 25 Feb 2015 14:13:10 -0500 Date: Wed, 25 Feb 2015 15:13:03 -0400 From: Eduardo Valentin To: Lukasz Majewski Cc: Kamil Debski , Jean Delvare , Guenter Roeck , Kukjin Kim , lm-sensors@lm-sensors.org, Linux PM list , "linux-samsung-soc@vger.kernel.org" , devicetree@vger.kernel.org, Lukasz Majewski , Kukjin Kim , linux-kernel@vger.kernel.org, Sjoerd Simons , Abhilash Kesavan , Abhilash Kesavan Subject: Re: [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Message-ID: <20150225191301.GA2983@developer.amazonguestwifi.org> References: <1418897591-18332-1-git-send-email-l.majewski@samsung.com> <1424878462-15511-1-git-send-email-l.majewski@samsung.com> <1424878462-15511-2-git-send-email-l.majewski@samsung.com> <20150225191123.GA2950@developer.amazonguestwifi.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline In-Reply-To: <20150225191123.GA2950@developer.amazonguestwifi.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3638 Lines: 113 --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 25, 2015 at 03:11:24PM -0400, Eduardo Valentin wrote: > On Wed, Feb 25, 2015 at 04:34:17PM +0100, Lukasz Majewski wrote: > > Explanation of several properties, which allow PWM fan working as a coo= ling > > device, have been embraced in this commit. > >=20 > > Signed-off-by: Lukasz Majewski > > --- > > Changes for v2: > > - Rename cooling-pwm-values to cooling-levels > > - Remove default-pulse-width property and stick to default hwmon policy > > Changes for v3: > > - Changing commit title from "hwmon: dts: Doc:" to "Documentation: dts" > > - Remove unnecessary properties > > - Set maximal cooling level to 230 instead of 255 > > Changes for v4: > > - None > > Changes for v5: > > - Move thermal-zones description to example section > > - Extending example section > >=20 > > --- > > .../devicetree/bindings/hwmon/pwm-fan.txt | 25 ++++++++++++++= +++++++- > > 1 file changed, 24 insertions(+), 1 deletion(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Docu= mentation/devicetree/bindings/hwmon/pwm-fan.txt > > index 610757c..645251b 100644 > > --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt > > +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt > > @@ -3,10 +3,33 @@ Bindings for a fan connected to the PWM lines > > Required properties: > > - compatible : "pwm-fan" > > - pwms : the PWM that is used to control the PWM fan > > +- cooling-levels : PWM duty cycle values in a range from 0 to 255 > > + which correspond to thermal cooling states > > =20 > > Example: > > - pwm-fan { > > + fan0: pwm-fan { > > compatible =3D "pwm-fan"; > > status =3D "okay"; > > pwms =3D <&pwm 0 10000 0>; > > + cooling-levels =3D <0 102 170 230>; > > + }; > > + > > + thermal-zones { > > + cpu_thermal: cpu-thermal { > > + cooling-min-state =3D <0>; > > + cooling-max-state =3D <3>; > > + #cooling-cells =3D <2>; > > + trips { > > + cpu_alert1: cpu-alert1 { > > + temperature =3D <100000>; /* millicelsius */ > > + hysteresis =3D <2000>; /* millicelsius */ > > + type =3D "passive"; > > + }; > > + }; > > + cooling-maps { > > + map0 { > > + trip =3D <&cpu_alert1>; > > + cooling-device =3D <&fan0 0 1>; > > + }; > > + }; >=20 > The above example has two issues: > (1) it is wrong, as the cooling device properties are in the thermal > zone node. > (2) has a misalignment / tabulation >=20 > Can you please fix that in your next version too? Apart from the above two issues you may add my=20 Acked-by: Eduardo Valentin >=20 > > }; > > --=20 > > 2.0.0.rc2 > >=20 --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJU7h60AAoJEMLUO4d9pOJWXwwH/ic5KhV2vXDFG0IMmnOlSIma ZtJas8ij2hCaO90lPWoNvBgOmsxdA/EMLjaKFxkiB54HGO5Pcnc3r7RylN9u3uRy X4SMc0RAzOB0pX85P/tM0k1XnejJylZe7Z/LF0lTYAab3FVLgqZ6JU2S0jSAVlkv pidXPyCmEFJ3SYX/OcJZk92WGJYRyEbEDEmiKfuZ6ExmmvaERr+rmzRGbc8VLW+L s4t9G62IhhgrXKS2zzsze4ZScFDPe81gEqXaXkar0UPJFb4Cxgkx0atFH5xdVDPI eirEFtUxmzvyOCP92IoFvPBV4eq0W1+4An1V8h5U+Yj5R+N3qtMN/I1YLLPXVDs= =pmq/ -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/