Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753422AbbBYU4M (ORCPT ); Wed, 25 Feb 2015 15:56:12 -0500 Received: from mail-ig0-f171.google.com ([209.85.213.171]:55646 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbbBYU4I (ORCPT ); Wed, 25 Feb 2015 15:56:08 -0500 Message-ID: <54EE36E4.5070404@linaro.org> Date: Wed, 25 Feb 2015 13:56:04 -0700 From: Al Stone User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Hanjun Guo , rjw@rjwysocki.net, lenb@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, robert.moore@intel.com, tony.luck@intel.com, fenghua.yu@intel.com CC: linaro-kernel@lists.linaro.org, linux-ia64@vger.kernel.org, linaro-acpi@lists.linaro.org, patches@linaro.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devel@acpica.org Subject: Re: [PATCH v3 2/9] ACPI: clear up warnings on use of printk reported by checkpatch.pl References: <1424824585-6405-1-git-send-email-al.stone@linaro.org> <1424824585-6405-3-git-send-email-al.stone@linaro.org> <54EDC64D.8040301@linaro.org> In-Reply-To: <54EDC64D.8040301@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1598 Lines: 52 On 02/25/2015 05:55 AM, Hanjun Guo wrote: > On 2015年02月25日 08:36, al.stone@linaro.org wrote: >> From: Al Stone >> >> In preparation for later splitting out some of the arch-dependent code from >> osl.c, clear up all the warnings reported by checkpatch.pl where pr_* should >> be used instead of printk(KERN_* ...). >> >> Signed-off-by: Al Stone >> --- >> drivers/acpi/osl.c | 46 +++++++++++++++++++--------------------------- >> 1 file changed, 19 insertions(+), 27 deletions(-) >> >> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c >> index 1dc3a3b..865317c 100644 >> --- a/drivers/acpi/osl.c >> +++ b/drivers/acpi/osl.c >> @@ -141,7 +141,7 @@ static u32 acpi_osi_handler(acpi_string interface, u32 >> supported) >> { >> if (!strcmp("Linux", interface)) { >> >> - printk_once(KERN_NOTICE FW_BUG PREFIX >> + pr_notice_once(FW_BUG PREFIX > > I think you can use pr_fmt() and then remove all the PREFIX in > this patch, just > > #define pr_fmt(fmt) "ACPI: " fmt > > in top of this file before all #includes. > > Thanks > Hanjun Argh. Yup, you're right. That was an oversight on my part. Fixed in next version. -- ciao, al ----------------------------------- Al Stone Software Engineer Linaro Enterprise Group al.stone@linaro.org ----------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/