Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932075AbbBYVE7 (ORCPT ); Wed, 25 Feb 2015 16:04:59 -0500 Received: from mail-we0-f175.google.com ([74.125.82.175]:40325 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753658AbbBYVEz (ORCPT ); Wed, 25 Feb 2015 16:04:55 -0500 Message-ID: <54EE38F1.10202@gmail.com> Date: Wed, 25 Feb 2015 23:04:49 +0200 From: Nikolai Kondrashov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Benjamin Tissoires , Jiri Kosina CC: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, DIGImend-devel Subject: Re: [PATCH 3/4] HID: uclogic: present only the working interfaces on the Huion tablets References: <1424822730-14938-1-git-send-email-benjamin.tissoires@redhat.com> <1424822730-14938-4-git-send-email-benjamin.tissoires@redhat.com> In-Reply-To: <1424822730-14938-4-git-send-email-benjamin.tissoires@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1634 Lines: 45 On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: > The Huion tablets show 3 interfaces. Only the first and the third > are currently used. > Also remove HID_QUIRK_MULTI_INPUT for the third interface to not > create more than needed input nodes. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/hid-uclogic.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/hid/hid-uclogic.c b/drivers/hid/hid-uclogic.c > index 397f1df..c03e076 100644 > --- a/drivers/hid/hid-uclogic.c > +++ b/drivers/hid/hid-uclogic.c > @@ -840,6 +840,11 @@ static int uclogic_probe(struct hid_device *hdev, > hid_err(hdev, "tablet enabling failed\n"); > return rc; > } > + } else if (intf->cur_altsetting->desc.bInterfaceNumber == 2) { > + hdev->quirks &= ~HID_QUIRK_MULTI_INPUT; > + } else { > + /* Ignore all unused interfaces */ > + return -ENODEV; > } > break; > } > I would hesitate to remove the mouse interface as there are relatively fresh UC-Logic tablets [1] out there which have a mouse, and which could respond to the initialization. These mice are of questionable usefulness, true, but leaving the interface enabled could make it easier for other people to experiment with using this driver with their tablets. What do you think, Benjamin? Nick [1] http://digimend.github.io/tablets/UC-Logic_TWHL850/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/