Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753696AbbBYVFL (ORCPT ); Wed, 25 Feb 2015 16:05:11 -0500 Received: from mail-wi0-f180.google.com ([209.85.212.180]:47412 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753035AbbBYVFF (ORCPT ); Wed, 25 Feb 2015 16:05:05 -0500 Message-ID: <54EE38FA.8070702@gmail.com> Date: Wed, 25 Feb 2015 23:04:58 +0200 From: Nikolai Kondrashov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Benjamin Tissoires , Jiri Kosina CC: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, DIGImend-devel Subject: Re: [PATCH 4/4] HID: uclogic: name the input nodes based on their tool References: <1424822730-14938-1-git-send-email-benjamin.tissoires@redhat.com> <1424822730-14938-5-git-send-email-benjamin.tissoires@redhat.com> In-Reply-To: <1424822730-14938-5-git-send-email-benjamin.tissoires@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1026 Lines: 26 On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: > We append "Pen", "Pad", "Mouse" or "Keyboard" suffix to the appropriate > input node to match what the Wacom driver does and be more convenient for > the user to know which one is which. As I said before, this is a very welcome change. Thanks, Benjamin! However, I'm not familiar with input_configured hook yet, so cannot give my Reviewed-by. > + if (suffix) { > + len = strlen(hdev->name) + 2 + strlen(suffix); > + name = devm_kzalloc(&hi->input->dev, len, GFP_KERNEL); > + if (name) { > + snprintf(name, len, "%s %s", hdev->name, suffix); > + hi->input->name = name; > + } I only feel a bit uneasy about duplicating buffer size knowledge here, as I said before, but the code is short, so it'll probably be OK. Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/