Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932225AbbBYVJ3 (ORCPT ); Wed, 25 Feb 2015 16:09:29 -0500 Received: from mail-ig0-f170.google.com ([209.85.213.170]:63695 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753418AbbBYVJ1 (ORCPT ); Wed, 25 Feb 2015 16:09:27 -0500 Date: Wed, 25 Feb 2015 13:09:24 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Rik van Riel cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Clark Williams , Li Zefan , Ingo Molnar , Luiz Capitulino , Mike Galbraith , cgroups@vger.kernel.org Subject: Re: [PATCH 2/2] cpusets,isolcpus: add file to show isolated cpus in cpuset In-Reply-To: <1424882288-2910-3-git-send-email-riel@redhat.com> Message-ID: References: <1424882288-2910-1-git-send-email-riel@redhat.com> <1424882288-2910-3-git-send-email-riel@redhat.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2094 Lines: 69 On Wed, 25 Feb 2015, riel@redhat.com wrote: > diff --git a/kernel/cpuset.c b/kernel/cpuset.c > index b544e5229d99..94bf59588e23 100644 > --- a/kernel/cpuset.c > +++ b/kernel/cpuset.c > @@ -1563,6 +1563,7 @@ typedef enum { > FILE_MEMORY_PRESSURE, > FILE_SPREAD_PAGE, > FILE_SPREAD_SLAB, > + FILE_ISOLCPUS, > } cpuset_filetype_t; > > static int cpuset_write_u64(struct cgroup_subsys_state *css, struct cftype *cft, > @@ -1704,6 +1705,20 @@ static ssize_t cpuset_write_resmask(struct kernfs_open_file *of, > return retval ?: nbytes; > } > > +static void cpuset_seq_print_isolcpus(struct seq_file *sf, struct cpuset *cs) > +{ > + cpumask_var_t my_isolated_cpus; > + > + if (!alloc_cpumask_var(&my_isolated_cpus, GFP_KERNEL)) > + return; > + > + cpumask_and(my_isolated_cpus, cs->cpus_allowed, cpu_isolated_map); > + > + seq_printf(sf, "%*pbl\n", nodemask_pr_args(my_isolated_cpus)); That unfortunately won't output anything, it needs to be cpumask_pr_args(). After that's fixed, feel free to add my Acked-by: David Rientjes > + > + free_cpumask_var(my_isolated_cpus); > +} > + > /* > * These ascii lists should be read in a single call, by using a user > * buffer large enough to hold the entire map. If read in smaller > @@ -1733,6 +1748,9 @@ static int cpuset_common_seq_show(struct seq_file *sf, void *v) > case FILE_EFFECTIVE_MEMLIST: > seq_printf(sf, "%*pbl\n", nodemask_pr_args(&cs->effective_mems)); > break; > + case FILE_ISOLCPUS: > + cpuset_seq_print_isolcpus(sf, cs); > + break; > default: > ret = -EINVAL; > } > @@ -1893,6 +1911,12 @@ static struct cftype files[] = { > .private = FILE_MEMORY_PRESSURE_ENABLED, > }, > > + { > + .name = "isolcpus", > + .seq_show = cpuset_common_seq_show, > + .private = FILE_ISOLCPUS, > + }, > + > { } /* terminate */ > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/