Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932401AbbBYV5I (ORCPT ); Wed, 25 Feb 2015 16:57:08 -0500 Received: from mail-we0-f182.google.com ([74.125.82.182]:43700 "EHLO mail-we0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932123AbbBYV5D (ORCPT ); Wed, 25 Feb 2015 16:57:03 -0500 From: Ameen Ali To: shahed.shaikh@qlogic.com, Dept-GELinuxNICDev@qlogic.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Ameen Ali Subject: [PATCH 6/6] qlcnic_dcb.c : possible division by zero. Date: Wed, 25 Feb 2015 23:56:43 +0200 Message-Id: <1424901403-6458-1-git-send-email-ameenali023@gmail.com> X-Mailer: git-send-email 2.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1052 Lines: 30 Whenever there is a division it is usually worthwhile to add some belt'n'braces code to ensure that cnt != 0, otherwise a machine signal can occur. Signed-off-by : Ameen Ali --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c index a72bcdd..c1d5e48 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c @@ -822,7 +822,7 @@ qlcnic_dcb_get_pg_tc_cfg_tx(struct net_device *netdev, int tc, u8 *prio, if (temp->valid && (pg == temp->pgid)) cnt++; } - + if(cnt != 0) tc_cfg->bwg_percent = (100 / cnt); *bw_per = tc_cfg->bwg_percent; } -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/