Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753509AbbBYWNI (ORCPT ); Wed, 25 Feb 2015 17:13:08 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:47912 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752593AbbBYWNG (ORCPT ); Wed, 25 Feb 2015 17:13:06 -0500 Date: Wed, 25 Feb 2015 17:13:04 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Ameen Ali cc: gregkh@linuxfoundation.org, , Subject: Re: [PATCH 5/5] ohci-tmio.c : missing 'break' statements In-Reply-To: <1424900670-6197-1-git-send-email-ameenali023@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1247 Lines: 41 The "break" statements are missing by intention. On Wed, 25 Feb 2015, Ameen Ali wrote: > Redundant bitwise operation on 'pm' in 'switch' statement. Why do you say the operations are redundant? > Signed-off-by : Ameen Ali > --- > drivers/usb/host/ohci-tmio.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c > index e9a6eec..c580615 100644 > --- a/drivers/usb/host/ohci-tmio.c > +++ b/drivers/usb/host/ohci-tmio.c > @@ -102,10 +102,13 @@ static void tmio_stop_hc(struct platform_device *dev) > dev_err(&dev->dev, "Unsupported amount of ports: %d\n", ohci->num_ports); > case 3: > pm |= CCR_PM_USBPW3; > + break; > case 2: > pm |= CCR_PM_USBPW2; > + break; > case 1: > pm |= CCR_PM_USBPW1; > + break; > } > tmio_iowrite8(0, tmio->ccr + CCR_INTC); > tmio_iowrite8(0, tmio->ccr + CCR_ILME); This patch is wrong. Figuring out why is left as an exercise. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/