Message-ID: <54EE4C7F.5040008@gmail.com>
Date: Thu, 26 Feb 2015 00:28:15 +0200
From: Nikolai Kondrashov <spbnick@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0
MIME-Version: 1.0
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
CC: Jiri Kosina <jkosina@suse.cz>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        DIGImend-devel <DIGImend-devel@lists.sourceforge.net>
Subject: Re: [PATCH 4/4] HID: uclogic: name the input nodes based on their
 tool
References: <1424822730-14938-1-git-send-email-benjamin.tissoires@redhat.com> <1424822730-14938-5-git-send-email-benjamin.tissoires@redhat.com> <54EE38FA.8070702@gmail.com> <20150225213652.GE3097@mail.corp.redhat.com>
In-Reply-To: <20150225213652.GE3097@mail.corp.redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1747
Lines: 43

On 02/25/2015 11:36 PM, Benjamin Tissoires wrote:
> On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote:
>> On 02/25/2015 02:05 AM, Benjamin Tissoires wrote:
>>> We append "Pen", "Pad", "Mouse" or "Keyboard" suffix to the appropriate
>>> input node to match what the Wacom driver does and be more convenient for
>>> the user to know which one is which.
>>
>> As I said before, this is a very welcome change. Thanks, Benjamin!
>> However, I'm not familiar with input_configured hook yet, so cannot give my
>> Reviewed-by.
>
> Well, the hook is called just before we present the input to the user
> space. So the input node is already set and its corresponding report
> has been parsed (or the whole descriptor has been parsed if
> QUIRK_MULTI_INPUT is not set).

Thanks for the explanation, but basing my Reviewed-by on your explanation
wouldn't be right, even though this seems simple :) I'll read up the kernel
code tomorrow.

>>
>>> +	if (suffix) {
>>> +		len = strlen(hdev->name) + 2 + strlen(suffix);
>>> +		name = devm_kzalloc(&hi->input->dev, len, GFP_KERNEL);
>>> +		if (name) {
>>> +			snprintf(name, len, "%s %s", hdev->name, suffix);
>>> +			hi->input->name = name;
>>> +		}
>>
>> I only feel a bit uneasy about duplicating buffer size knowledge here, as I
>> said before, but the code is short, so it'll probably be OK.
>
> I am not quite sure what you mean with "duplicating buffer size
> knowledge"...

Argh, nevermind, just sleepy me, sorry. You fixed it, thanks, looks fine :)

Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/