Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753840AbbBYWc3 (ORCPT ); Wed, 25 Feb 2015 17:32:29 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:52007 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753621AbbBYWc1 (ORCPT ); Wed, 25 Feb 2015 17:32:27 -0500 From: "Rafael J. Wysocki" To: Scot Doyle Cc: "Zheng, Lv" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ACPI / EC: Remove non-standard log emphasis Date: Wed, 25 Feb 2015 23:55:51 +0100 Message-ID: <3416235.WAfNBEHG25@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.19.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1AE640813FDE7649BE1B193DEA596E88026D8057@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 40 On Wednesday, February 25, 2015 03:01:08 PM Scot Doyle wrote: > On Wed, 25 Feb 2015, Zheng, Lv wrote: > ... > > > I was using "+++++"/"#####"/"*****" to filter different EC log entries which makes debugging easier. > > > And, if we changed this from pr_info into pr_debug, then we will have nothing in the suspend/resume logs for the EC device. > > > While there are plenty of such log entries for each of other devices. > > > So I really doubt what's the meaning of such a change. > > > Could it improve anything or just make debugging more difficult for developers? > > > > IMO, it's better to introduce such kind of code in the head of ec.c: > > > > #ifdef DEBUG_FILTER > > #define EC_LOG_DEV "+++++" > > #define EC_LOG_CMD "*****" > > #define EC_LOG_EVT "#####" > > ... > > #else > > #define EC_LOG_DEV > > #define EC_LOG_CMD > > #define EC_LOG_EVT > > #endif > > > > And wrap the pr_info, pr_debug using filter enabled new macros - ec_info, ec_debug so that we won't see the filters in the normal dmesg output and the filters are still available for the developers. > > > > Thanks and best regards > > -Lv > > I agree, would you be willing to submit it? Yes, sounds good to me too! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/