Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753112AbbBZBSa (ORCPT ); Wed, 25 Feb 2015 20:18:30 -0500 Received: from mail-ig0-f182.google.com ([209.85.213.182]:41853 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752676AbbBZBS2 (ORCPT ); Wed, 25 Feb 2015 20:18:28 -0500 Date: Wed, 25 Feb 2015 19:18:24 -0600 From: Bjorn Helgaas To: Phong Tran Cc: tinamdar@apm.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Fabio Estevam Subject: Re: [PATCH] PCI: xgene: Fix the map_bus callback prototype Message-ID: <20150226011824.GU6220@google.com> References: <1424686899-7869-1-git-send-email-tranmanphong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424686899-7869-1-git-send-email-tranmanphong@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1228 Lines: 36 [+cc Fabio] On Mon, Feb 23, 2015 at 05:21:39PM +0700, Phong Tran wrote: > The return value should be void __iomem *. > Tested by compile only. > > Signed-off-by: Phong Tran I've already applied an identical patch from Fabio Estevam. I added Arnd's ack to it and also mentioned you in the credits, Phong. > --- > drivers/pci/host/pci-xgene.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c > index aab5547..9c3bfd8 100644 > --- a/drivers/pci/host/pci-xgene.c > +++ b/drivers/pci/host/pci-xgene.c > @@ -127,7 +127,7 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset) > return false; > } > > -static int xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn, > +static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn, > int offset) > { > struct xgene_pcie_port *port = bus->sysdata; > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/