Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753487AbbBZCCK (ORCPT ); Wed, 25 Feb 2015 21:02:10 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54759 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753434AbbBZCCI (ORCPT ); Wed, 25 Feb 2015 21:02:08 -0500 Date: Thu, 26 Feb 2015 11:01:06 +0900 From: Mark Brown To: Adrian Remonda Cc: Jonathan Corbet , "open list:SPI SUBSYSTEM" , "open list:DOCUMENTATION" , open list Message-ID: <20150226020106.GU6236@finisterre.sirena.org.uk> References: <1424891324-24784-1-git-send-email-adrianremonda@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="skgCfLFhCSVZJUH9" Content-Disposition: inline In-Reply-To: <1424891324-24784-1-git-send-email-adrianremonda@gmail.com> X-Cookie: for ARTIFICIAL FLAVORING!! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 106.188.12.244 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: spidev_test: Added functionalities X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1594 Lines: 41 --skgCfLFhCSVZJUH9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 25, 2015 at 08:08:44PM +0100, Adrian Remonda wrote: > This is a patch that add functionalities to the spidev_test tool found > in Documentation/spi/spidev_test.c. > - Cleaned hexadecimal dump > - Added verbose mode to see the transmitting sequence > - Added input buffer from the terminal. Now it is possible to send > string and hexadecimal data as an input parameter: Since this is doing several different things then it should be a series of patches rather than a single patch - please see SubmittingPatches for advice on how to prepare patches for submission. It is hard to review changes which do more than one thing. --skgCfLFhCSVZJUH9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU7n5hAAoJECTWi3JdVIfQNGwH/Ri/NJss2tT7za5c7bGYSEsY gu7gJVs9Qssg43WGqCUY+V772seAVfiHfWJgh58rHqY1sCs+W6U3CXJRU+t5py5P A02PIxHYem/y1xvP/oIxpZNJV6ajgEd+EJzKeYQHtnjDOfuJtX+KI8DQdUi6lMkD SKw7iILDI6xBZ0ghfr3TA1+AWeav8xR7xuc9T6JOnAnRwrseu3s6USSE/4CCqU8W veowrLMWVnyXKabp9ggx7XayhHioQ641nrtuLgrdsO8gLD0iIfa88ALb0f6pgEsB SG4nalW47MZNxU8a+AkQytElelUlDTwVjdeJcJzlQ5DqFi33+v9h5JDa+splBRE= =OlM7 -----END PGP SIGNATURE----- --skgCfLFhCSVZJUH9-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/