Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752937AbbBZGrO (ORCPT ); Thu, 26 Feb 2015 01:47:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42810 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752193AbbBZGrN (ORCPT ); Thu, 26 Feb 2015 01:47:13 -0500 Date: Thu, 26 Feb 2015 14:45:11 +0800 From: Baoquan He To: MegaBrutal Cc: Kees Cook , Linux kernel , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Vivek Goyal , Jan Beulich , Junjie Mao , Andi Kleen , "Thomas D." Subject: Re: [PATCH] x86, boot: skip relocs when load address unchanged Message-ID: <20150226064511.GC4636@dhcp-16-105.nay.redhat.com> References: <20150116005146.GA4212@www.outflux.net> <20150120130457.GG2461@dhcp-16-105.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1239 Lines: 27 On 02/26/15 at 07:29am, MegaBrutal wrote: > Thanks for this patch, and good to see it in mainline! > > This actually fixes the problem I reported here: > https://lkml.org/lkml/2014/12/1/15 > > I wish it to be backported into the Ubuntu Utopic kernel asap. > > > This patch works for me. And good to see it's being merged. About the > > patch log, I would say relocations do unexpected things when the kernel > > is above 1G since randomization is done from 16M to 1G, namely > > CONFIG_RANDOMIZE_BASE_MAX_OFFSET. So above 1G kernel text mapping will > > step into kernel module mapping region. > > I'm just speculating, but is it the reason why I only get problems > when I boot with kexec? Maybe it's only then when the kernel gets > above 1G. Otherwise, the kernels boot properly when they are booted > from GRUB. Yeah, kexec loads kernel at the top of physical memory. And above 1G kernel mapping will step into module mapping area and collapse system. Grub doesn't incur this problem. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/