Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753355AbbBZHud (ORCPT ); Thu, 26 Feb 2015 02:50:33 -0500 Received: from mail7.hitachi.co.jp ([133.145.228.42]:44143 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753312AbbBZHub (ORCPT ); Thu, 26 Feb 2015 02:50:31 -0500 Message-ID: <54EED03E.9030601@hitachi.com> Date: Thu, 26 Feb 2015 16:50:22 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Naohiro Aota Cc: Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] perf probe: export get_real_path References: <1424934769-19481-1-git-send-email-naota@elisp.net> In-Reply-To: <1424934769-19481-1-git-send-email-naota@elisp.net> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2235 Lines: 60 (2015/02/26 16:12), Naohiro Aota wrote: > Export it to use from util/probe-finder.c Please fold this in to the next patch, since this exported symbol is not used until applying the next one. BTW, since get_real_path is compiled only when HAVE_DWARF_SUPPORT=y, we can also move it into probe-finder.c. Could you also move it into probe-finder.c and export it at probe-finder.h? Thank you, > > Signed-off-by: Naohiro Aota > --- > tools/perf/util/probe-event.c | 2 +- > tools/perf/util/probe-event.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 919937e..1d0d505 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -520,7 +520,7 @@ static int try_to_find_probe_trace_events(struct perf_probe_event *pev, > * a newly allocated path on success. > * Return 0 if file was found and readable, -errno otherwise. > */ > -static int get_real_path(const char *raw_path, const char *comp_dir, > +int get_real_path(const char *raw_path, const char *comp_dir, > char **new_path) > { > const char *prefix = symbol_conf.source_prefix; > diff --git a/tools/perf/util/probe-event.h b/tools/perf/util/probe-event.h > index e01e994..30a3391 100644 > --- a/tools/perf/util/probe-event.h > +++ b/tools/perf/util/probe-event.h > @@ -135,6 +135,8 @@ extern int show_available_vars(struct perf_probe_event *pevs, int npevs, > struct strfilter *filter, bool externs); > extern int show_available_funcs(const char *module, struct strfilter *filter, > bool user); > +extern int get_real_path(const char *raw_path, const char *comp_dir, > + char **new_path); > > /* Maximum index number of event-name postfix */ > #define MAX_EVENT_INDEX 1024 > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/