Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753590AbbBZKaA (ORCPT ); Thu, 26 Feb 2015 05:30:00 -0500 Received: from mail-we0-f172.google.com ([74.125.82.172]:37483 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbbBZK3z convert rfc822-to-8bit (ORCPT ); Thu, 26 Feb 2015 05:29:55 -0500 MIME-Version: 1.0 In-Reply-To: References: <1424455277-29983-1-git-send-email-mcoquelin.stm32@gmail.com> <1424455277-29983-3-git-send-email-mcoquelin.stm32@gmail.com> <20150220194756.GS19388@pengutronix.de> Date: Thu, 26 Feb 2015 11:29:52 +0100 Message-ID: Subject: Re: [PATCH v2 02/18] ARM: ARMv7M: Enlarge vector table to 256 entries From: Maxime Coquelin To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Daniel Lezcano , Thomas Gleixner , Linus Walleij , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2383 Lines: 73 2015-02-23 11:33 GMT+01:00 Maxime Coquelin : > 2015-02-20 20:47 GMT+01:00 Uwe Kleine-König : >> On Fri, Feb 20, 2015 at 07:01:01PM +0100, Maxime Coquelin wrote: >>> From Cortex-M reference manuals, the nvic supports up to 240 interrupts. >>> So the number of entries in vectors table is up to 256. >>> >>> This patch adds a new config flag to specify the number of external interrupts. >>> Some ifdeferies are added in order to respect the natural alignment without >>> wasting too much space on smaller systems. >>> >>> Signed-off-by: Maxime Coquelin >>> --- >>> arch/arm/kernel/entry-v7m.S | 13 +++++++++---- >>> arch/arm/mm/Kconfig | 15 +++++++++++++++ >>> 2 files changed, 24 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/arm/kernel/entry-v7m.S b/arch/arm/kernel/entry-v7m.S >>> index 8944f49..68cde36 100644 >>> --- a/arch/arm/kernel/entry-v7m.S >>> +++ b/arch/arm/kernel/entry-v7m.S >>> @@ -117,9 +117,14 @@ ENTRY(__switch_to) >>> ENDPROC(__switch_to) >>> >>> .data >>> - .align 8 >>> +#if CONFIG_CPUV7M_NUM_IRQ <= 112 >> I would have called this CONFIG_CPU_V7M_NUM_IRQ to match the already >> existing CPU_V7M symbol. > > That's better indeed. > It will be changed in v3. > >> >>> + .align 9 >>> +#else >>> + .align 10 >>> +#endif >>> + >> >> Other than that: >> Acked-by: Uwe Kleine-König >> >> Who do you target to apply this series? > > I guess it should go through Russell's Patch Tracking System? Sorry, I answered your question too quickly. I meant this patch should go through Russell's Patch Tracking System. For the other patches, I think it should be picked by their respective maintainers. Or I can create an immutable tag (on github or kernel.org?) that will be merged by the different sub-systems? What would you advise? Thanks, Maxime > > Thanks, > Maxime >> >> Best regards >> Uwe >> >> -- >> Pengutronix e.K. | Uwe Kleine-König | >> Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/