Date: Thu, 26 Feb 2015 12:30:54 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Toshi Kani <toshi.kani@hp.com>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
        akpm@linux-foundation.org, arnd@arndb.de, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, jgross@suse.com,
        stefan.bader@canonical.com, luto@amacapital.net, hmh@hmh.eng.br,
        yigal@plexistor.com, konrad.wilk@oracle.com, Elliott@hp.com
Subject: Re: [PATCH v8 7/7] x86, mm: Add set_memory_wt() for WT
Message-ID: <20150226113054.GA4191@gmail.com>
References: <1424823301-30927-1-git-send-email-toshi.kani@hp.com>
 <1424823301-30927-8-git-send-email-toshi.kani@hp.com>
 <20150225072228.GA13061@gmail.com>
 <1424877601.17007.108.camel@misato.fc.hp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1424877601.17007.108.camel@misato.fc.hp.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1196
Lines: 35


* Toshi Kani <toshi.kani@hp.com> wrote:

> On Wed, 2015-02-25 at 08:22 +0100, Ingo Molnar wrote:
> > * Toshi Kani <toshi.kani@hp.com> wrote:
> > 
> > > +int set_pages_array_wt(struct page **pages, int addrinarray)
> > > +{
> > > +	return _set_pages_array(pages, addrinarray, _PAGE_CACHE_MODE_WT);
> > > +}
> > > +EXPORT_SYMBOL(set_pages_array_wt);
> > 
> > So by default we make new APIs EXPORT_SYMBOL_GPL(): we 
> > don't want proprietary modules mucking around with new code 
> > PAT interfaces, we only want modules we can analyze and fix 
> > in detail.
> 
> Right.  I have one question for this case.  This 
> set_pages_array_wt() extends the set_pages_array_xx() 
> family, which are all exported with EXPORT_SYMBOL() 
> today.  In this case, should we keep them exported in the 
> consistent manner, or should we still use GPL when adding 
> a new one?

Still keep it GPL, it's a new API that old modules 
obviously don't use.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/