Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932882AbbBZONu (ORCPT ); Thu, 26 Feb 2015 09:13:50 -0500 Received: from mail-qg0-f45.google.com ([209.85.192.45]:33889 "EHLO mail-qg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932386AbbBZONr (ORCPT ); Thu, 26 Feb 2015 09:13:47 -0500 MIME-Version: 1.0 In-Reply-To: <20150225230449.GM3226@pd.tnic> References: <1424822419-10267-1-git-send-email-dvlasenk@redhat.com> <1424822419-10267-4-git-send-email-dvlasenk@redhat.com> <20150225230449.GM3226@pd.tnic> From: Denys Vlasenko Date: Thu, 26 Feb 2015 15:13:26 +0100 Message-ID: Subject: Re: [PATCH 4/7] x86: entry.S: use JZ mnemonic after TEST, not JE To: Borislav Petkov Cc: Denys Vlasenko , Andy Lutomirski , Linus Torvalds , Steven Rostedt , Ingo Molnar , "H. Peter Anvin" , Oleg Nesterov , Frederic Weisbecker , Alexei Starovoitov , Will Drewry , Kees Cook , X86 ML , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1359 Lines: 34 On Thu, Feb 26, 2015 at 12:04 AM, Borislav Petkov wrote: > On Wed, Feb 25, 2015 at 01:00:16AM +0100, Denys Vlasenko wrote: >> After TEST insn, JE actually performs "jump if zero", >> let's use JZ mnemonic instead. >> >> No code changes, but less confusion. >> >> Signed-off-by: Denys Vlasenko >> CC: Linus Torvalds >> CC: Steven Rostedt >> CC: Ingo Molnar >> CC: Borislav Petkov >> CC: "H. Peter Anvin" >> CC: Andy Lutomirski >> CC: Oleg Nesterov >> CC: Frederic Weisbecker >> CC: Alexei Starovoitov >> CC: Will Drewry >> CC: Kees Cook >> CC: x86@kernel.org >> CC: linux-kernel@vger.kernel.org >> --- >> arch/x86/kernel/entry_64.S | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Borislav Petkov Andy, please don't take this patch yet, there are about a dozen more instances of TEST which need similar treatment. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/