Message-ID: <54EF2CD6.2050608@suse.de>
Date: Thu, 26 Feb 2015 15:25:26 +0100
From: Alexander Graf <agraf@suse.de>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: "J. German Rivera" <German.Rivera@freescale.com>,
        gregkh@linuxfoundation.org, arnd@arndb.de,
        linux-kernel@vger.kernel.org
CC: stuart.yoder@freescale.com, Kim.Phillips@freescale.com,
        scottwood@freescale.com, bhamciu1@freescale.com, R89243@freescale.com,
        Geoff.Thorpe@freescale.com, bhupesh.sharma@freescale.com,
        nir.erez@freescale.com, richard.schmitt@freescale.com
Subject: Re: [PATCH v2 1/1] drivers/bus: fsl-mc object allocator driver
References: <1424818219-16142-1-git-send-email-German.Rivera@freescale.com> <1424818219-16142-2-git-send-email-German.Rivera@freescale.com>
In-Reply-To: <1424818219-16142-2-git-send-email-German.Rivera@freescale.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1265
Lines: 31


On 24.02.15 23:50, J. German Rivera wrote:
> The fsl-mc object allocator driver manages "allocatable" fsl-mc
> objects such as DPBPs, DPMCPs and DPCONs. It provides services to

I'd recommend to explain what these abbreviations mean. It's
ridiculously hard to remember what they are about. So please put their
full name at least into the patch description and into the headers of
their respective handling files.

Also, can we maybe split the patches into the minimal set required to
get one driver working? I hate to see lots of functions land in upstream
that are never called from anywhere. At the end of the day, I care about
vertical coverage, not horizontal. All of your patches so far are
horizontal.

So please pick one driver, choose the subset required to make bus
enumeration, DPRC handling and the few objects required for that one
driver work and then let's try to push it upstream.

Once that's done we can easily extend the interface incrementally with
every other new driver from that point on.


Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/