MIME-Version: 1.0
In-Reply-To: <1424959720-7628-1-git-send-email-dvlasenk@redhat.com>
References: <1424959720-7628-1-git-send-email-dvlasenk@redhat.com>
From: Andy Lutomirski <luto@amacapital.net>
Date: Thu, 26 Feb 2015 07:10:26 -0800
Message-ID: <CALCETrWBmb+zELcqG0GGOKGCDV0kPA_CMB-bvNkDUdhb06hiSA@mail.gmail.com>
Subject: Re: [PATCH] x86: fix a bug introduced by "allocate full pt_regs" commit
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@kernel.org>,
        Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 798
Lines: 19

On Thu, Feb 26, 2015 at 6:08 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
> If syscall_trace_enter_phase1 returns 0,
> code restores %rax from pt_regs->ax, but should restore it from
> pt_regs->orig_ax.
>
> The bug crept in because LOAD_ARGS macro was very sublty different
> from RESTORE_ARGS, it had only two callsites and only this one
> was using that difference.

I folded this in to the original patch to avoid breaking bisection.  I
put the missing -ARGOFFSET in and then removed it again in the
appropriate place later in the series.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/