Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754067AbbBZPQw (ORCPT ); Thu, 26 Feb 2015 10:16:52 -0500 Received: from mail-lb0-f174.google.com ([209.85.217.174]:34957 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753554AbbBZPQv (ORCPT ); Thu, 26 Feb 2015 10:16:51 -0500 MIME-Version: 1.0 In-Reply-To: References: <1424822419-10267-1-git-send-email-dvlasenk@redhat.com> <1424822419-10267-4-git-send-email-dvlasenk@redhat.com> <20150225230449.GM3226@pd.tnic> From: Andy Lutomirski Date: Thu, 26 Feb 2015 07:16:28 -0800 Message-ID: Subject: Re: [PATCH 4/7] x86: entry.S: use JZ mnemonic after TEST, not JE To: Denys Vlasenko Cc: Borislav Petkov , Denys Vlasenko , Linus Torvalds , Steven Rostedt , Ingo Molnar , "H. Peter Anvin" , Oleg Nesterov , Frederic Weisbecker , Alexei Starovoitov , Will Drewry , Kees Cook , X86 ML , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1784 Lines: 48 On Thu, Feb 26, 2015 at 6:13 AM, Denys Vlasenko wrote: > On Thu, Feb 26, 2015 at 12:04 AM, Borislav Petkov wrote: >> On Wed, Feb 25, 2015 at 01:00:16AM +0100, Denys Vlasenko wrote: >>> After TEST insn, JE actually performs "jump if zero", >>> let's use JZ mnemonic instead. >>> >>> No code changes, but less confusion. >>> >>> Signed-off-by: Denys Vlasenko >>> CC: Linus Torvalds >>> CC: Steven Rostedt >>> CC: Ingo Molnar >>> CC: Borislav Petkov >>> CC: "H. Peter Anvin" >>> CC: Andy Lutomirski >>> CC: Oleg Nesterov >>> CC: Frederic Weisbecker >>> CC: Alexei Starovoitov >>> CC: Will Drewry >>> CC: Kees Cook >>> CC: x86@kernel.org >>> CC: linux-kernel@vger.kernel.org >>> --- >>> arch/x86/kernel/entry_64.S | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Acked-by: Borislav Petkov > > Andy, please don't take this patch yet, there are about a dozen > more instances of TEST which need similar treatment. I'm declaring a temporary moratorium on new development here until the already-queued stuff is in -tip, looks okay, and we're in an appropriate part of the cycle. The series is already huge. IOW I'm not applying this or the other pending patches yet. --Andy -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/