Date: Thu, 26 Feb 2015 18:22:22 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andi Kleen <ak@linux.intel.com>, Andi Kleen <andi@firstfloor.org>,
        x86@kernel.org, linux-kernel@vger.kernel.org, oleg@redhat.com,
        paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au, mingo@kernel.org
Subject: Re: [RFC][PATCH] module: Optimize __module_address() using a latched
 RB-tree
Message-ID: <20150226172222.GX21418@twins.programming.kicks-ass.net>
References: <1424482737-958-1-git-send-email-andi@firstfloor.org>
 <20150223170436.GC5029@twins.programming.kicks-ass.net>
 <20150223174340.GD27767@tassilo.jf.intel.com>
 <20150226114309.GR21418@twins.programming.kicks-ass.net>
 <2127583772.183982.1424966563927.JavaMail.zimbra@efficios.com>
 <20150226164356.GU21418@twins.programming.kicks-ass.net>
 <2065867235.184322.1424969735591.JavaMail.zimbra@efficios.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2065867235.184322.1424969735591.JavaMail.zimbra@efficios.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 606
Lines: 15

On Thu, Feb 26, 2015 at 04:55:35PM +0000, Mathieu Desnoyers wrote:
> > +static unsigned long mod_value(struct module *mod, int idx)
> > +{
> > +	if (idx & init_bit)
> 
> Hrm, my first reflex is to look for a "init_bit" variable here.
> Should we use caps for enum entries instead ? e.g. INIT_BIT ?

I could change those bit things to CPP and then use caps :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/