Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753941AbbBZSVc (ORCPT ); Thu, 26 Feb 2015 13:21:32 -0500 Received: from mga02.intel.com ([134.134.136.20]:32743 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752483AbbBZSVb (ORCPT ); Thu, 26 Feb 2015 13:21:31 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,654,1418112000"; d="scan'208";a="683940159" Date: Thu, 26 Feb 2015 10:19:42 -0800 (PST) From: Vikas Shivappa X-X-Sender: vikas@vshiva-Udesk To: Borislav Petkov cc: Vikas Shivappa , Vikas Shivappa , linux-kernel@vger.kernel.org, matt.fleming@intel.com, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org, peterz@infradead.org, will.auld@intel.com, dave.hansen@intel.com, andi.kleen@intel.com, tony.luck@intel.com, kanaka.d.juvva@intel.com Subject: Re: [PATCH 1/7] x86/intel_rdt: Intel Cache Allocation Technology detection In-Reply-To: <20150225112153.GB3226@pd.tnic> Message-ID: References: <1424819804-4082-1-git-send-email-vikas.shivappa@linux.intel.com> <1424819804-4082-2-git-send-email-vikas.shivappa@linux.intel.com> <20150224234334.GB3706@pd.tnic> <20150225112153.GB3226@pd.tnic> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2000 Lines: 67 On Wed, 25 Feb 2015, Borislav Petkov wrote: > On Tue, Feb 24, 2015 at 04:42:10PM -0800, Vikas Shivappa wrote: >>>> + >>>> + pr_info("cbmlength:%u,Closs: %u\n", cbm_len, maxid); >>> >>> This text message needs to be much more user-friendly if it is going out >>> to the console unconditionally. >>> >> >> bit mask lengh: number of CLOSids: ? . it should print with the module name >> as well which should help understand what it is for. > > Right, if I haven't read the SDM on RDT, I still don't understand what > those mean. What is the need for that message at all, what is it telling > me? > > Can you show an example from a machine with RDT and explain what it is > good for? This would be an indication that the System support RDT. On a system with RDT would see a print. intel_rdt: cbmlength: xx , CLOss:xx This is documented in the RDT documentation that is added in the patch and the code also mentiones the Intel SDM section which details the feature. The RDT is expected to be used by advanced users atlest the ones who would use the cgroup RDT interface , knows about the class of service , bit mask etc.. The use cases are also documented in the RDT document in cgroups/rdt.txt (the last patch in this series) > >>>> +config CGROUP_RDT >>>> + bool "Resource Director Technology cgroup subsystem" >>>> + depends on X86_64 >>> >>> depends on X86_64 && CPU_SUP_INTEL >>> >>> Also, this should probably also depend on CGROUP-something or so >>> AFAICT... >> >> This is with in the if CGROUPS > > Right, but you still need the CPU_SUP_INTEL dependency as !Intel x86 > doesn't need that code built. Will add this dependency.. > > Thanks. > > -- > Regards/Gruss, > Boris. > > ECO tip #101: Trim your mails when you reply. > -- > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/