Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753994AbbBZSZL (ORCPT ); Thu, 26 Feb 2015 13:25:11 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:50608 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752748AbbBZSZI convert rfc822-to-8bit (ORCPT ); Thu, 26 Feb 2015 13:25:08 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH 01/12] ARM: dts: apq8064: add RPM regulators support From: Kumar Gala In-Reply-To: <1424678093-12966-1-git-send-email-srinivas.kandagatla@linaro.org> Date: Thu, 26 Feb 2015 12:25:03 -0600 Cc: linux-arm-msm@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <424678035-12862-1-git-send-email-srinivas.kandagatla@linaro.org> <1424678093-12966-1-git-send-email-srinivas.kandagatla@linaro.org> To: Srinivas Kandagatla X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1862 Lines: 54 On Feb 23, 2015, at 1:54 AM, Srinivas Kandagatla wrote: > This patch adds rpm node to apq8064 dt as rpm would be used by other > devices for regulator support. Also adds all the regulators in the rpm. > > Signed-off-by: Srinivas Kandagatla > --- > arch/arm/boot/dts/qcom-apq8064.dtsi | 241 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 241 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi > index b3154c0..db5fc59 100644 > --- a/arch/arm/boot/dts/qcom-apq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi > @@ -3,6 +3,7 @@ > #include "skeleton.dtsi" > #include > #include > +#include > #include > #include > > @@ -246,6 +247,246 @@ > #reset-cells = <1>; > }; > > + l2cc: clock-controller@2011000 { > + compatible = "syscon"; > + reg = <0x2011000 0x1000>; > + }; > + > + rpm@108000 { > + compatible = "qcom,rpm-apq8064"; > + reg = <0x108000 0x1000>; > + qcom,ipc = <&l2cc 0x8 2>; > + > + interrupts = <0 19 0>, <0 21 0>, <0 22 0>; > + interrupt-names = "ack", "err", "wakeup"; > + Can you use the defines for GIC for the interrupts. Also, I think the last property should probably be level high instead of 0. - k -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/