Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754584AbbBZTAO (ORCPT ); Thu, 26 Feb 2015 14:00:14 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:37977 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754058AbbBZTAL (ORCPT ); Thu, 26 Feb 2015 14:00:11 -0500 MIME-Version: 1.0 In-Reply-To: <1424678093-12966-1-git-send-email-srinivas.kandagatla@linaro.org> References: <424678035-12862-1-git-send-email-srinivas.kandagatla@linaro.org> <1424678093-12966-1-git-send-email-srinivas.kandagatla@linaro.org> Date: Thu, 26 Feb 2015 11:00:09 -0800 Message-ID: Subject: Re: [PATCH 01/12] ARM: dts: apq8064: add RPM regulators support From: Bjorn Andersson To: Srinivas Kandagatla Cc: Kumar Gala , linux-arm-msm , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1038 Lines: 26 On Sun, Feb 22, 2015 at 11:54 PM, Srinivas Kandagatla wrote: > This patch adds rpm node to apq8064 dt as rpm would be used by other > devices for regulator support. Also adds all the regulators in the rpm. > This looks good, with Kumars suggestion of GIT defines Reviewed-by: Bjorn Andersson However, this binding is not merged yet and Stephen have requesting a complete redesign of the binding as well as the code. So that has to be concluded first, I presume. Separate of that, as it's highly likely that everyone will follow the pcb design guidelines for apq8064 the vin-supplies should be okay to specify at this level (and not in all board files). Perhaps also the switching frequencies for the SMPSs? Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/